public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Mat Hostetter <mat@lcs.mit.edu>
Cc: bug-binutils@gnu.org, binutils@sourceware.org
Subject: Re: gas SEGV reporting an error + patch
Date: Mon, 17 Jul 2006 12:50:00 -0000	[thread overview]
Message-ID: <20060717125010.GM18571@bubble.grove.modra.org> (raw)
In-Reply-To: <7u7j2k3po7.fsf@ld-1.internal.tilera.com>

On Tue, Jul 11, 2006 at 03:30:16PM -0400, Mat Hostetter wrote:
> The bug is that 'report_op_error' incorrectly uses 'file' and 'line'
> in the 'else' case where they are not initialized. Because the value
> of 'file' is garbage, it is of course somewhat random whether you will
> see a crash.
> 
> The fix is trivial: since there is no location information available,
> use 'as_bad' instead of 'as_bad_where', as it was already doing for
> other errors in the 'else' case.

Applied.  Thanks!

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

           reply	other threads:[~2006-07-17 12:50 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <7u7j2k3po7.fsf@ld-1.internal.tilera.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060717125010.GM18571@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sourceware.org \
    --cc=bug-binutils@gnu.org \
    --cc=mat@lcs.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).