From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: binutils@sourceware.org
Subject: Re: [PATCH]: Add DWARF debugging format support for arm-wince-pe
Date: Sat, 05 Aug 2006 18:46:00 -0000 [thread overview]
Message-ID: <20060805184652.GA615@nevyn.them.org> (raw)
In-Reply-To: <44D48C6B.30000@portugalmail.pt>
On Sat, Aug 05, 2006 at 01:17:47PM +0100, Pedro Alves wrote:
> Ok. Than should I 'else if' ?:
>
> if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0
> || strcmp (name, "pe-i386") == 0
> || strcmp (name, "pei-i386") == 0)
> return 1;
> else if (strcmp (name, "pe-arm-little") == 0
> || strcmp (name, "pei-arm-little") == 0)
> return 0;
>
> or, should i386 return 0 too ?:
>
> if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0
> || strcmp (name, "pe-i386") == 0
> || strcmp (name, "pei-i386") == 0
> || strcmp (name, "pe-arm-little") == 0
> || strcmp (name, "pei-arm-little") == 0)
> return 0;
>
>
> or, simply leave i386 and arm returning 1, until this hack
> is cleaned up?
I'd do the last option.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-08-05 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-05 0:39 Pedro Alves
2006-08-05 3:20 ` Daniel Jacobowitz
2006-08-05 12:17 ` Pedro Alves
2006-08-05 18:46 ` Daniel Jacobowitz [this message]
2006-08-05 6:57 ` Andreas Schwab
2006-08-05 12:18 ` Pedro Alves
2006-08-06 14:15 ` Nick Clifton
2006-08-06 14:41 ` Pedro Alves
2006-08-06 14:45 ` Nick Clifton
2006-08-06 14:52 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060805184652.GA615@nevyn.them.org \
--to=drow@false.org \
--cc=binutils@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).