From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22673 invoked by alias); 5 Aug 2006 18:46:57 -0000 Received: (qmail 22665 invoked by uid 22791); 5 Aug 2006 18:46:57 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 05 Aug 2006 18:46:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G9RAi-0000AV-N3; Sat, 05 Aug 2006 14:46:52 -0400 Date: Sat, 05 Aug 2006 18:46:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: binutils@sourceware.org Subject: Re: [PATCH]: Add DWARF debugging format support for arm-wince-pe Message-ID: <20060805184652.GA615@nevyn.them.org> Mail-Followup-To: Pedro Alves , binutils@sourceware.org References: <44D3E8BE.2090304@portugalmail.pt> <20060805032025.GA18061@nevyn.them.org> <44D48C6B.30000@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D48C6B.30000@portugalmail.pt> User-Agent: Mutt/1.5.11+cvs20060403 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00055.txt.bz2 On Sat, Aug 05, 2006 at 01:17:47PM +0100, Pedro Alves wrote: > Ok. Than should I 'else if' ?: > > if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0 > || strcmp (name, "pe-i386") == 0 > || strcmp (name, "pei-i386") == 0) > return 1; > else if (strcmp (name, "pe-arm-little") == 0 > || strcmp (name, "pei-arm-little") == 0) > return 0; > > or, should i386 return 0 too ?: > > if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0 > || strcmp (name, "pe-i386") == 0 > || strcmp (name, "pei-i386") == 0 > || strcmp (name, "pe-arm-little") == 0 > || strcmp (name, "pei-arm-little") == 0) > return 0; > > > or, simply leave i386 and arm returning 1, until this hack > is cleaned up? I'd do the last option. -- Daniel Jacobowitz CodeSourcery