From: Eric Botcazou <ebotcazou@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Fix DW_CFA_set_loc handling
Date: Tue, 26 Sep 2006 13:26:00 -0000 [thread overview]
Message-ID: <200609261456.40370.ebotcazou@adacore.com> (raw)
In-Reply-To: <20060926123840.GA4556@sunsite.mff.cuni.cz>
Jakub,
> Recent http://gcc.gnu.org/PR22313 change (including gcc 4.1 branch) started
> (unnecessarily) using DW_CFA_set_loc at the start of all FDEs, but
> unfortunately linker .eh_frame optimizations didn't handle that well.
> If FDE encoding is pc relative or linker is changing it from absptr
> to pc relative, we need to adjust the DW_CFA_set_loc operand accordingly.
>
> Tested with make check on x86_64-linux, visual inspection of x86_64
> readelf -wf libc.so.6 (this was seriously broken before) and visual
> inspection of a hacked up test for absptr -> pcrel conversion.
This sounds a bit frightening, not everyone can afford to use binutils
mainline with the 4.1.x compiler. We already found a nasty fallout
http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00285.html
so the change seems to be really destabilizing at this point.
Would you be OK to jointly ask Roger to back it out on the 4.1 branch?
--
Eric Botcazou
next prev parent reply other threads:[~2006-09-26 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 12:56 Jakub Jelinek
2006-09-26 13:26 ` Eric Botcazou [this message]
2006-09-26 16:22 ` David Daney
2006-09-26 18:08 ` Eric Botcazou
2006-09-26 19:06 ` David Daney
2006-09-26 14:04 ` H. J. Lu
2006-09-26 14:58 ` Jakub Jelinek
2006-10-02 16:45 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609261456.40370.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=binutils@sources.redhat.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).