From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19995 invoked by alias); 26 Sep 2006 12:56:34 -0000 Received: (qmail 19986 invoked by uid 22791); 26 Sep 2006 12:56:33 -0000 X-Spam-Check-By: sourceware.org Received: from province.act-europe.fr (HELO province.act-europe.fr) (212.157.227.214) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Sep 2006 12:56:31 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-province.act-europe.fr (Postfix) with ESMTP id 6AD9F4ACF9; Tue, 26 Sep 2006 14:56:28 +0200 (CEST) Received: from province.act-europe.fr ([127.0.0.1]) by localhost (province.act-europe.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 30076-06; Tue, 26 Sep 2006 14:56:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by province.act-europe.fr (Postfix) with ESMTP id 1CA794ACF6; Tue, 26 Sep 2006 14:56:28 +0200 (CEST) From: Eric Botcazou To: Jakub Jelinek Subject: Re: [PATCH] Fix DW_CFA_set_loc handling Date: Tue, 26 Sep 2006 13:26:00 -0000 User-Agent: KMail/1.7.1 Cc: binutils@sources.redhat.com References: <20060926123840.GA4556@sunsite.mff.cuni.cz> In-Reply-To: <20060926123840.GA4556@sunsite.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609261456.40370.ebotcazou@adacore.com> Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00296.txt.bz2 Jakub, > Recent http://gcc.gnu.org/PR22313 change (including gcc 4.1 branch) started > (unnecessarily) using DW_CFA_set_loc at the start of all FDEs, but > unfortunately linker .eh_frame optimizations didn't handle that well. > If FDE encoding is pc relative or linker is changing it from absptr > to pc relative, we need to adjust the DW_CFA_set_loc operand accordingly. > > Tested with make check on x86_64-linux, visual inspection of x86_64 > readelf -wf libc.so.6 (this was seriously broken before) and visual > inspection of a hacked up test for absptr -> pcrel conversion. This sounds a bit frightening, not everyone can afford to use binutils mainline with the 4.1.x compiler. We already found a nasty fallout http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00285.html so the change seems to be really destabilizing at this point. Would you be OK to jointly ask Roger to back it out on the 4.1 branch? -- Eric Botcazou