public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: add an assertion to gas/write.c
@ 2006-10-24  6:50 Ben Elliston
  2006-10-26  0:30 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Elliston @ 2006-10-24  6:50 UTC (permalink / raw)
  To: binutils

This is the first in a serious of miscellaneous patches I have
accumulated in my checkout.  Tested with an all-targets build.  Okay
to commit?

Ben

2006-10-24  Ben Elliston  <bje@au.ibm.com>

        * write.c (chain_frchains_together_1): Assert that this function
        never returns a pointer to the auto variable `dummy'.

Index: write.c
===================================================================
RCS file: /cvs/src/src/gas/write.c,v
retrieving revision 1.102
diff -u -p -r1.102 write.c
--- write.c     22 Sep 2006 11:35:13 -0000      1.102
+++ write.c     24 Oct 2006 04:46:44 -0000
@@ -394,6 +394,7 @@ chain_frchains_together_1 (segT section,
        }
     }
   assert (prev_frag->fr_type != 0);
+  assert (prev_frag != &dummy);
   prev_frag->fr_next = 0;
   return prev_frag;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: add an assertion to gas/write.c
  2006-10-24  6:50 PATCH: add an assertion to gas/write.c Ben Elliston
@ 2006-10-26  0:30 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2006-10-26  0:30 UTC (permalink / raw)
  To: Ben Elliston; +Cc: binutils

On Tue, Oct 24, 2006 at 02:47:55PM +1000, Ben Elliston wrote:
> 2006-10-24  Ben Elliston  <bje@au.ibm.com>
> 
>         * write.c (chain_frchains_together_1): Assert that this function
>         never returns a pointer to the auto variable `dummy'.

OK.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-10-26  0:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-24  6:50 PATCH: add an assertion to gas/write.c Ben Elliston
2006-10-26  0:30 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).