Put back OTHER_BSS_SECTIONS

Put back OTHER_BSS_SECTIONS

[H. J. Lu]

Hi Alan,

Your patch

http://sourceware.org/ml/binutils/2006-10/msg00289.html

put back OTHER_BSS_SECTIONS. Can we apply

http://sourceware.org/ml/binutils/2005-08/msg00071.html

to restore the rest?

Thanks.


H.J.

Re: Put back OTHER_BSS_SECTIONS

[H. J. Lu]

On Wed, Oct 25, 2006 at 07:43:40AM -0700, H. J. Lu wrote:
> Hi Alan,
> 
> Your patch
> 
> http://sourceware.org/ml/binutils/2006-10/msg00289.html
> 
> put back OTHER_BSS_SECTIONS. Can we apply
> 
> http://sourceware.org/ml/binutils/2005-08/msg00071.html
> 
> to restore the rest?
> 

This is the patch to restore OTHER_BSS_SECTIONS.


H.J.
---
2006-10-25  H.J. Lu  <hongjiu.lu@intel.com>

	* emulparams/hppa64linux.sh (LARGE_SECTIONS): Renamed to ...
	(OTHER_BSS_SECTIONS): This.
	* scripttempl/elf.sc (OTHER_BSS_SECTIONS): Support LARGE_SECTIONS.
	(LARGE_SECTIONS): Move .lbss sections to OTHER_BSS_SECTIONS.

--- ld/emulparams/hppa64linux.sh.bss	2006-05-30 09:45:32.000000000 -0700
+++ ld/emulparams/hppa64linux.sh	2006-10-25 09:38:32.000000000 -0700
@@ -28,7 +28,7 @@ OTHER_READWRITE_SECTIONS="
   .dlt          ${RELOCATING-0} : { *(.dlt) }"
 
 # The PA64 ELF port has an additional huge bss section.
-LARGE_SECTIONS=".hbss         ${RELOCATING-0} : { *(.hbss) }"
+OTHER_BSS_SECTIONS=".hbss         ${RELOCATING-0} : { *(.hbss) }"
 
 #OTHER_SYMBOLS='PROVIDE (__TLS_SIZE = SIZEOF (.tbss));'
 OTHER_SYMBOLS='
--- ld/scripttempl/elf.sc.bss	2006-10-25 09:24:27.000000000 -0700
+++ ld/scripttempl/elf.sc	2006-10-25 09:38:32.000000000 -0700
@@ -177,13 +177,15 @@ test "${LARGE_SECTIONS}" = "yes" && REL_
   .rela.lbss    ${RELOCATING-0} : { *(.rela.lbss${RELOCATING+ .rela.lbss.* .rela.gnu.linkonce.lb.*}) }
   .rel.lrodata  ${RELOCATING-0} : { *(.rel.lrodata${RELOCATING+ .rel.lrodata.* .rel.gnu.linkonce.lr.*}) }
   .rela.lrodata ${RELOCATING-0} : { *(.rela.lrodata${RELOCATING+ .rela.lrodata.* .rela.gnu.linkonce.lr.*}) }"
-test "${LARGE_SECTIONS}" = "yes" && LARGE_SECTIONS="
+test "${LARGE_SECTIONS}" = "yes" && OTHER_BSS_SECTIONS="
+  ${OTHER_BSS_SECTIONS}
   .lbss ${RELOCATING-0} :
   {
     *(.dynlbss)
     *(.lbss${RELOCATING+ .lbss.* .gnu.linkonce.lb.*})
     *(LARGE_COMMON)
-  }
+  }"
+test "${LARGE_SECTIONS}" = "yes" && LARGE_SECTIONS="
   .lrodata ${RELOCATING-0} ${RELOCATING+ALIGN(${MAXPAGESIZE}) + (. & (${MAXPAGESIZE} - 1))} :
   {
     *(.lrodata${RELOCATING+ .lrodata.* .gnu.linkonce.lr.*})

Re: Put back OTHER_BSS_SECTIONS

[Alan Modra]

On Wed, Oct 25, 2006 at 10:06:06AM -0700, H. J. Lu wrote:
> On Wed, Oct 25, 2006 at 07:43:40AM -0700, H. J. Lu wrote:
> > Hi Alan,
> > 
> > Your patch
> > 
> > http://sourceware.org/ml/binutils/2006-10/msg00289.html
> > 
> > put back OTHER_BSS_SECTIONS. Can we apply
> > 
> > http://sourceware.org/ml/binutils/2005-08/msg00071.html
> > 
> > to restore the rest?
> > 
> 
> This is the patch to restore OTHER_BSS_SECTIONS.

Are you sure?  The current script has an align and
OTHER_BSS_END_SYMBOLS before .lbss.  If you have checked that changing
this will make no difference then the patch is OK.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: Put back OTHER_BSS_SECTIONS

[H. J. Lu]

On Thu, Oct 26, 2006 at 09:16:11AM +0930, Alan Modra wrote:
> On Wed, Oct 25, 2006 at 10:06:06AM -0700, H. J. Lu wrote:
> > On Wed, Oct 25, 2006 at 07:43:40AM -0700, H. J. Lu wrote:
> > > Hi Alan,
> > > 
> > > Your patch
> > > 
> > > http://sourceware.org/ml/binutils/2006-10/msg00289.html
> > > 
> > > put back OTHER_BSS_SECTIONS. Can we apply
> > > 
> > > http://sourceware.org/ml/binutils/2005-08/msg00071.html
> > > 
> > > to restore the rest?
> > > 
> > 
> > This is the patch to restore OTHER_BSS_SECTIONS.
> 
> Are you sure?  The current script has an align and
> OTHER_BSS_END_SYMBOLS before .lbss.  If you have checked that changing
> this will make no difference then the patch is OK.

It shouldn't be a problem. If both LARGE_SECTIONS and
OTHER_BSS_END_SYMBOLS are defined, I believe that OTHER_BSS_END_SYMBOLS
should cover .lbss.


H.J.