From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10259 invoked by alias); 13 Apr 2007 14:41:16 -0000 Received: (qmail 10242 invoked by uid 22791); 13 Apr 2007 14:41:14 -0000 X-Spam-Check-By: sourceware.org Received: from smtp106.sbc.mail.mud.yahoo.com (HELO smtp106.sbc.mail.mud.yahoo.com) (68.142.198.205) by sourceware.org (qpsmtpd/0.31) with SMTP; Fri, 13 Apr 2007 15:41:10 +0100 Received: (qmail 97601 invoked from network); 13 Apr 2007 14:41:08 -0000 Received: from unknown (HELO lucon.org) (hjjean@sbcglobal.net@75.61.85.239 with login) by smtp106.sbc.mail.mud.yahoo.com with SMTP; 13 Apr 2007 14:41:08 -0000 X-YMail-OSG: TPvuqhYVM1lOsJYdcyhRPwiO60Y5Q_4dbfFK6Vej_jdmEccC0Tr9DcqHZyvWyvdBQpaNKp1EKA-- Received: by lucon.org (Postfix, from userid 500) id D79B546EEEB; Fri, 13 Apr 2007 07:41:06 -0700 (PDT) Date: Fri, 13 Apr 2007 14:49:00 -0000 From: "H. J. Lu" To: Kai Tietz Cc: binutils@sources.redhat.com Subject: Re: PATCH: windres Message-ID: <20070413144106.GA28469@lucon.org> References: <20070412165645.GA13677@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00173.txt.bz2 On Fri, Apr 13, 2007 at 04:19:25PM +0200, Kai Tietz wrote: > "H. J. Lu" wrote on 12.04.2007 18:56:45: > > > On Thu, Apr 12, 2007 at 06:23:21PM +0200, Kai Tietz wrote: > > > "H. J. Lu" wrote on 12.04.2007 17:55:25: > > > > > > > Can you try to use existing data type I/O routines in bfd? > > > > > > You mean the endian swapping ? > > > > > > > Yes. Also you should use > > > > unsigned char characteristics [4]; > > > > instead of > > > > unsigned long characteristics; > > > > or > > > > unsigned int characteristics; > > Nightmares, ... 8| I begun to modify structure using character arrays ... > I come to the point, that this means for big parts of windres better a > complete rewrite. Structures with internal/external scope and data > modifications are really wired. > May we should first use my last patch, so that the problem is solved, and > then I will begin to reorganize the windres tool to be host idependent. By > this I can add some missing resource types to it. > > What do you think about my suggestion to continue ? > That is fine with me. If you do this, you don't need to handle endian and just replace long with int since you will rewrite it later anyway. H.J.