From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18066 invoked by alias); 16 Apr 2007 21:59:00 -0000 Received: (qmail 18057 invoked by uid 22791); 16 Apr 2007 21:58:59 -0000 X-Spam-Check-By: sourceware.org Received: from smtp104.sbc.mail.mud.yahoo.com (HELO smtp104.sbc.mail.mud.yahoo.com) (68.142.198.203) by sourceware.org (qpsmtpd/0.31) with SMTP; Mon, 16 Apr 2007 22:58:56 +0100 Received: (qmail 32229 invoked from network); 16 Apr 2007 21:58:52 -0000 Received: from unknown (HELO lucon.org) (hjjean@sbcglobal.net@75.61.81.46 with login) by smtp104.sbc.mail.mud.yahoo.com with SMTP; 16 Apr 2007 21:58:52 -0000 X-YMail-OSG: cFIMaK8VM1mmn40k3wkD_T2j6TFyeE7lIVYl.OEB.ky8iH8H Received: by lucon.org (Postfix, from userid 500) id 925F346EE93; Mon, 16 Apr 2007 14:58:49 -0700 (PDT) Date: Mon, 16 Apr 2007 22:20:00 -0000 From: "H. J. Lu" To: Kai Tietz , binutils@sources.redhat.com Subject: Re: PATCH: windres Message-ID: <20070416215849.GA23226@lucon.org> References: <20070413144106.GA28469@lucon.org> <20070416210710.GB16652@ednor.casa.cgf.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070416210710.GB16652@ednor.casa.cgf.cx> User-Agent: Mutt/1.4.2.2i Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00215.txt.bz2 On Mon, Apr 16, 2007 at 05:07:10PM -0400, Christopher Faylor wrote: > On Mon, Apr 16, 2007 at 11:20:49AM +0200, Kai Tietz wrote: > >"H. J. Lu" wrote on 13.04.2007 16:41:06: > > > >> > Nightmares, ... 8| I begun to modify structure using character arrays > >... > >> > I come to the point, that this means for big parts of windres better a > > > >> > complete rewrite. Structures with internal/external scope and data > >> > modifications are really wired. > >> > May we should first use my last patch, so that the problem is solved, > >and > >> > then I will begin to reorganize the windres tool to be host > >idependent. By > >> > this I can add some missing resource types to it. > >> > > >> > What do you think about my suggestion to continue ? > >> > > >> > >> That is fine with me. If you do this, you don't need to handle > >> endian and just replace long with int since you will rewrite it > >> later anyway. > > > >This is the patch changing the windres source using int instead of long. I > >bootstrap it on cygwin 32 and for x86_64-mingw. > >This patch does not solve the endian problem, reasoned by the use of > >fwrite/fread. > >ChangeLog for binutils/: > > If you are assuming that int means 32 bits, wouldn't it make sense to > use a type like u_int32_t which explicitly spells that out? u_int32_t is a good idea if it doesn't require extra change since this is a temporary patch until windres can be rewritten properly. H.J.