From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: binutils@sourceware.org, Matt Thomas <matt@netbsd.org>
Cc: Alan Modra <amodra@bigpond.net.au>
Subject: Fallout for VAX (was: --enable-checking for gas)
Date: Sat, 21 Apr 2007 12:50:00 -0000 [thread overview]
Message-ID: <20070421124236.GA2411@lug-owl.de> (raw)
In-Reply-To: <20070421051631.GO6840@bubble.grove.modra.org>
[-- Attachment #1: Type: text/plain, Size: 3952 bytes --]
On Sat, 2007-04-21 14:46:32 +0930, Alan Modra <amodra@bigpond.net.au> wrote:
> gas/
> * as.h (ENABLE_CHECKING): Default define to 0.
> (know): Assert if ENABLE_CHECKING.
> (struct relax_type): Remove superfluous declaration.
> * configure.in (--enable-checking): New.
> * configure: Regenerate.
> * config.in: Regenerate.
> * config/tc-ppc.c (ppc_setup_opcodes): Do checks when ENABLE_CHECKING.
> Check for duplicate powerpc_operands entries.
Now where know() really does do its work for CVS builds, we see some
fallout for eg. vax-linux-uclibc:
gcc -DHAVE_CONFIG_H -I. -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas -I. -D_GNU_SOURCE -I. -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas -I../bfd -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/../include -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/.. -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/../bfd -DLOCALEDIR="\"/tmp/build-temp-vax-linux-uclibc/install/usr/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c /tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config/atof-vax.c
cc1: warnings being treated as errors
/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config/atof-vax.c: In function #md_atof#:
/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config/atof-vax.c:438: warning: comparison between signed and unsigned
make[3]: *** [atof-vax.o] Error 1
make[3]: Leaving directory `/tmp/build-temp-vax-linux-uclibc/build/binutils/gas'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/build-temp-vax-linux-uclibc/build/binutils/gas'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/build-temp-vax-linux-uclibc/build/binutils/gas'
make: *** [all-gas] Error 2
If Matt doesn't object, I'd like to install this patch to fix it:
2007-04-21 Jan-Benedict Glaw <jbglaw@lug-owl.de>
gas/
* config/atof-vax.c: Update copyright year.
(atof_vax_sizeof): Return unsigned int instead of int.
(md_atof): Make number_of_chars unsigned int, too.
(MAXIMUM_NUMBER_OF_LITTLENUMS): Remove single space.
--- src-binutils-fresh/gas/config/atof-vax.c 2005-05-05 11:12:52.000000000 +0200
+++ src-binutils-hacked/gas/config/atof-vax.c 2007-04-21 14:34:51.000000000 +0200
@@ -1,5 +1,5 @@
/* atof_vax.c - turn a Flonum into a VAX floating point number
- Copyright 1987, 1992, 1993, 1995, 1997, 1999, 2000, 2005
+ Copyright 1987, 1992, 1993, 1995, 1997, 1999, 2000, 2005, 2007
Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@@ -35,7 +35,7 @@ int flonum_gen2vax (int, FLONUM_TYPE *,
/* Number of chars in flonum type 'letter'. */
-static int
+static unsigned int
atof_vax_sizeof (int letter)
{
int return_value;
@@ -386,7 +386,7 @@ flonum_gen2vax (int format_letter, /* On
Floating point literal.
Number of chars we used for the literal. */
-#define MAXIMUM_NUMBER_OF_LITTLENUMS 8 /* For .hfloats. */
+#define MAXIMUM_NUMBER_OF_LITTLENUMS 8 /* For .hfloats. */
char *
md_atof (int what_statement_type,
@@ -395,7 +395,7 @@ md_atof (int what_statement_type,
{
LITTLENUM_TYPE words[MAXIMUM_NUMBER_OF_LITTLENUMS];
char kind_of_float;
- int number_of_chars;
+ unsigned int number_of_chars;
LITTLENUM_TYPE *littlenumP;
switch (what_statement_type)
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: 23:53 <@jbglaw> So, ich kletter' jetzt mal ins Bett.
the second : 23:57 <@jever2> .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?)
00:00 <@jbglaw> jever2: *patsch*
00:01 <@jever2> *aua*, wofür, Gedanken sind frei!
00:02 <@jbglaw> Nee, freie Gedanken, die sind seit 1984 doch aus!
00:03 <@jever2> 1984? ich bin erst seit 1985 verheiratet!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-04-21 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 6:50 --enable-checking for gas Alan Modra
2007-04-21 7:32 ` Alan Modra
2007-04-21 13:32 ` Alan Modra
2007-04-21 12:50 ` Jan-Benedict Glaw [this message]
2007-04-21 13:39 ` Fallout for VAX (was: --enable-checking for gas) Alan Modra
2007-04-21 17:23 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070421124236.GA2411@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=matt@netbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).