From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23038 invoked by alias); 23 Apr 2007 13:51:55 -0000 Received: (qmail 23028 invoked by uid 22791); 23 Apr 2007 13:51:54 -0000 X-Spam-Check-By: sourceware.org Received: from pool-72-70-61-13.bstnma.fios.verizon.net (HELO cgf.cx) (72.70.61.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 23 Apr 2007 14:51:51 +0100 Received: by cgf.cx (Postfix, from userid 201) id C4FA013C037; Mon, 23 Apr 2007 09:51:49 -0400 (EDT) Date: Mon, 23 Apr 2007 14:23:00 -0000 From: Christopher Faylor To: binutils@sourceware.org, Kai Tietz Subject: Re: PATCH: windres Message-ID: <20070423135149.GA32108@trixie.casa.cgf.cx> Mail-Followup-To: binutils@sourceware.org, Kai Tietz References: <20070423122553.GA1513@ednor.casa.cgf.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00306.txt.bz2 On Mon, Apr 23, 2007 at 02:56:03PM +0200, Kai Tietz wrote: >binutils-owner@sourceware.org wrote on 23.04.2007 14:25:54: >>I'm sorry that I missed this before but what was the rationale for >>replacing the (f)lex file with a .c file? That seems like a step >>backwards to me. > >The use of flex looks more professional, but at a closer look a pure c >lexer is getting easier to maintain and more efficant. E.g. gcc use >now for a long term no flex anymore to implement the c token scanner. >To use flex is sometimes as to break a fly on the wheel. Speed is not really an issue in this case but, regardless, *claims* of efficiency are not really useful unless they are accompanied by actual data. Your implementation is ~4K larger than the .l version and, since it is is a complete reimplementation, there is no way to tell what regressions there may be. Have you tried running the test suite on your version, anemic as the windres test may be? Changing the current version of the lexer to accept more characters seems like it would be trivial, FWIW. cgf