[PATCH] Build failure of current CVS on arm

[PATCH] Build failure of current CVS on arm

[Aurelien Jarno]

The current CVS of binutils fails to build on arm, due to warning treated as error:

gcc -DHAVE_CONFIG_H -I. -I../../gas -I. -D_GNU_SOURCE -I. -I../../gas -I../bfd -I../../gas/config -I../../gas/../include -I../../gas/.. -I../../gas/../bfd -DLOCALEDIR="\"/usr/share/locale\""   -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c ../../gas/config/tc-arm.c
cc1: warnings being treated as errors
../../gas/config/tc-arm.c: In function ‘md_apply_fix’:
../../gas/config/tc-arm.c:18699: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18699: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18739: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18739: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18778: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18778: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18818: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18818: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18823: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
../../gas/config/tc-arm.c:18823: warning: format ‘%08lX’ expects type ‘long unsigned int’, but argument 4 has type ‘bfd_vma’
make[5]: *** [tc-arm.o] Erreur 1


Please find below a patch to fix that.

--- binutils-2.17cvs20070426.orig/gas/config/tc-arm.c
+++ binutils-2.17cvs20070426/gas/config/tc-arm.c
@@ -18696,7 +18696,7 @@
          if (encoded_addend == (unsigned int) FAIL)
 	   as_bad_where (fixP->fx_file, fixP->fx_line,
 	                 _("the offset 0x%08lX is not representable"),
-                         addend_abs);
+                         (unsigned long) addend_abs);
 
          /* Extract the instruction.  */
          insn = md_chars_to_number (buf, INSN_SIZE);
@@ -18736,7 +18736,7 @@
           if (addend_abs >= 0x1000)
 	    as_bad_where (fixP->fx_file, fixP->fx_line,
 	  	          _("bad offset 0x%08lX (only 12 bits available for the magnitude)"),
-                          addend_abs);
+                          (unsigned long) addend_abs);
 
           /* Extract the instruction.  */
           insn = md_chars_to_number (buf, INSN_SIZE);
@@ -18775,7 +18775,7 @@
           if (addend_abs >= 0x100)
 	    as_bad_where (fixP->fx_file, fixP->fx_line,
 	  	          _("bad offset 0x%08lX (only 8 bits available for the magnitude)"),
-                          addend_abs);
+                          (unsigned long) addend_abs);
 
           /* Extract the instruction.  */
           insn = md_chars_to_number (buf, INSN_SIZE);
@@ -18815,12 +18815,12 @@
           if (addend_abs & 0x3)
 	    as_bad_where (fixP->fx_file, fixP->fx_line,
 	  	          _("bad offset 0x%08lX (must be word-aligned)"),
-                          addend_abs);
+                          (unsigned long) addend_abs);
 
           if ((addend_abs >> 2) > 0xff)
 	    as_bad_where (fixP->fx_file, fixP->fx_line,
 	  	          _("bad offset 0x%08lX (must be an 8-bit number of words)"),
-                          addend_abs);
+                          (unsigned long) addend_abs);
 
           /* Extract the instruction.  */
           insn = md_chars_to_number (buf, INSN_SIZE);



-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [PATCH] Build failure of current CVS on arm

[Daniel Jacobowitz]

On Sat, Apr 28, 2007 at 12:08:21PM +0200, Aurelien Jarno wrote:
> The current CVS of binutils fails to build on arm, due to warning treated as error:

You can reproduce this by building on any 32-bit platform with
--target=arm-linux --enable-64-bit-bfd.  I've applied your patch -
thanks!


-- 
Daniel Jacobowitz
CodeSourcery