From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4339 invoked by alias); 9 Jul 2007 18:56:10 -0000 Received: (qmail 4329 invoked by uid 22791); 9 Jul 2007 18:56:09 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jul 2007 18:56:07 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5BDE49829E for ; Mon, 9 Jul 2007 18:56:06 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3F8C39817C for ; Mon, 9 Jul 2007 18:56:06 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I7yOy-0006DJ-BT for binutils@sourceware.org; Mon, 09 Jul 2007 14:56:04 -0400 Date: Mon, 09 Jul 2007 19:52:00 -0000 From: Daniel Jacobowitz To: binutils@sourceware.org Subject: Re: PATCH: PR binutils/4756: addr2line fails on relocatable linux kernel Message-ID: <20070709185604.GA23863@caradoc.them.org> Mail-Followup-To: binutils@sourceware.org References: <20070709184340.GA14140@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070709184340.GA14140@lucon.org> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00191.txt.bz2 On Mon, Jul 09, 2007 at 11:43:40AM -0700, H.J. Lu wrote: > bfd_simple_get_relocated_section_content shouldn't apply relocations > on executable and shared library with relocations. This patch uses > the same check in binutils/objdump.c. Do you see any way to fix this that does not drop support for shared libraries where debug info has not been relocated? I don't think so, and I do not object to your patch. But this function was originally added for shared libraries, not for ET_REL objects. I'm sure you remember the several different ways binutils treated relocations in shared library debug info over time. -- Daniel Jacobowitz CodeSourcery