From: Alan Modra <amodra@bigpond.net.au>
To: msnyder@sonic.net
Cc: binutils@sourceware.org
Subject: Re: [PATCH] linker.c, null string
Date: Wed, 25 Jul 2007 00:11:00 -0000 [thread overview]
Message-ID: <20070724233632.GG27905@bubble.grove.modra.org> (raw)
In-Reply-To: <12546.12.7.175.2.1185310570.squirrel@webmail.sonic.net>
On Tue, Jul 24, 2007 at 01:56:10PM -0700, msnyder@sonic.net wrote:
> Shouldn't use NULL to denote an invalid string, because the pointer
> will be passed to functions that will dereference it (Coverity).
Actually, it won't ever be dereferenced. The function that is called,
_bfd_generic_link_add_one_symbol, only uses "string" when handling
warning and indirect symbols.
> * linker.c (generic_link_add_symbol_list): Use an invalid string
> rather than null, since the pointer will be dereferenced.
So introducing another string constant is just bloat. We do like to
fix warnings though. I'm committing the following.
* linker.c (generic_link_add_symbol_list): Warning fix.
Index: bfd/linker.c
===================================================================
RCS file: /cvs/src/src/bfd/linker.c,v
retrieving revision 1.59
diff -u -p -r1.59 linker.c
--- bfd/linker.c 3 Jul 2007 14:26:42 -0000 1.59
+++ bfd/linker.c 24 Jul 2007 23:25:56 -0000
@@ -1316,7 +1316,7 @@ generic_link_add_symbol_list (bfd *abfd,
struct generic_link_hash_entry *h;
struct bfd_link_hash_entry *bh;
- name = bfd_asymbol_name (p);
+ string = name = bfd_asymbol_name (p);
if (((p->flags & BSF_INDIRECT) != 0
|| bfd_is_ind_section (p->section))
&& pp + 1 < ppend)
@@ -1329,12 +1329,9 @@ generic_link_add_symbol_list (bfd *abfd,
{
/* The name of P is actually the warning string, and the
next symbol is the one to warn about. */
- string = name;
pp++;
name = bfd_asymbol_name (*pp);
}
- else
- string = NULL;
bh = NULL;
if (! (_bfd_generic_link_add_one_symbol
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2007-07-24 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 22:19 msnyder
2007-07-25 0:11 ` Alan Modra [this message]
2007-07-25 0:49 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724233632.GG27905@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).