From: "H.J. Lu" <hjl@lucon.org>
To: msnyder@sonic.net, binutils@sourceware.org
Subject: Re: [patch] coff-i386, guard against null
Date: Thu, 26 Jul 2007 13:46:00 -0000 [thread overview]
Message-ID: <20070726130808.GA9417@lucon.org> (raw)
In-Reply-To: <20070726114139.GA15404@caradoc.them.org>
On Thu, Jul 26, 2007 at 07:41:39AM -0400, Daniel Jacobowitz wrote:
> On Wed, Jul 25, 2007 at 07:18:55PM -0700, H.J. Lu wrote:
> > On Wed, Jul 25, 2007 at 05:21:13PM -0700, msnyder@sonic.net wrote:
> > > Other code in this function checks to see if sym is null.
> > > If it's null here, it'll fail.
> > >
> >
> > > 2007-07-25 Michael Snyder <msnyder@access-company.com>
> > >
> > > * coff-i386.c (coff_i386_rtype_to_howto): Guard against null.
> > >
> >
> > I prefer BFD_ASSERT (sym != NULL).
>
> BFD_ASSERT returns, though.
I'd like to know when this condition happens. Crash is better than
silent return. That is how BFD_ASSERT is used other places.
H.J.
next prev parent reply other threads:[~2007-07-26 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 0:54 msnyder
2007-07-26 2:20 ` H.J. Lu
2007-07-26 12:34 ` Daniel Jacobowitz
2007-07-26 13:46 ` H.J. Lu [this message]
2007-07-26 18:54 ` msnyder
2007-07-26 20:01 ` H.J. Lu
2007-07-26 23:52 ` msnyder
2007-07-27 1:04 ` H.J. Lu
2007-07-27 1:42 ` msnyder
2007-07-26 13:08 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726130808.GA9417@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sourceware.org \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).