From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21803 invoked by alias); 26 Jul 2007 13:08:13 -0000 Received: (qmail 21794 invoked by uid 22791); 26 Jul 2007 13:08:12 -0000 X-Spam-Check-By: sourceware.org Received: from sccrmhc12.comcast.net (HELO sccrmhc12.comcast.net) (63.240.77.82) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jul 2007 13:08:10 +0000 Received: from lucon.org ([24.6.230.138]) by comcast.net (sccrmhc12) with ESMTP id <2007072613080801200mknsie>; Thu, 26 Jul 2007 13:08:08 +0000 Received: by lucon.org (Postfix, from userid 500) id 381ACF7F60; Thu, 26 Jul 2007 06:08:08 -0700 (PDT) Date: Thu, 26 Jul 2007 13:46:00 -0000 From: "H.J. Lu" To: msnyder@sonic.net, binutils@sourceware.org Subject: Re: [patch] coff-i386, guard against null Message-ID: <20070726130808.GA9417@lucon.org> References: <22002.12.7.175.2.1185409273.squirrel@webmail.sonic.net> <20070726021855.GA29523@lucon.org> <20070726114139.GA15404@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070726114139.GA15404@caradoc.them.org> User-Agent: Mutt/1.5.14 (2007-02-12) Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00453.txt.bz2 On Thu, Jul 26, 2007 at 07:41:39AM -0400, Daniel Jacobowitz wrote: > On Wed, Jul 25, 2007 at 07:18:55PM -0700, H.J. Lu wrote: > > On Wed, Jul 25, 2007 at 05:21:13PM -0700, msnyder@sonic.net wrote: > > > Other code in this function checks to see if sym is null. > > > If it's null here, it'll fail. > > > > > > > > 2007-07-25 Michael Snyder > > > > > > * coff-i386.c (coff_i386_rtype_to_howto): Guard against null. > > > > > > > I prefer BFD_ASSERT (sym != NULL). > > BFD_ASSERT returns, though. I'd like to know when this condition happens. Crash is better than silent return. That is how BFD_ASSERT is used other places. H.J.