From: Alan Modra <amodra@bigpond.net.au>
To: msnyder@sonic.net
Cc: binutils@sourceware.org
Subject: Re: [PATCH] linker.c, check for null return from bfd_hash_allocate
Date: Thu, 26 Jul 2007 23:57:00 -0000 [thread overview]
Message-ID: <20070726235201.GO11649@bubble.grove.modra.org> (raw)
In-Reply-To: <5873.12.7.175.2.1185488205.squirrel@webmail.sonic.net>
On Thu, Jul 26, 2007 at 03:16:45PM -0700, msnyder@sonic.net wrote:
> 2007-07-26 Michael Snyder <msnyder@svkmacdonelllnx>
>
> * linker.c (bfd_section_already_linked_table_insert): Change
> return type from void to boolean. Return FALSE on failure.
> (_bfd_generic_section_already_linked): Test return value of
> bfd_section_already_linked_table_insert, call fatal on error.
>
> * elflink.c (_bfd_elf_section_already_linked): Test return value
> of bfd_section_already_linked_table_insert, call fatal on error.
>
> * libbfd-in.h (bfd_section_already_linked_table_insert): Update
> return type to bfd_boolean.
>
> * libbfd.h: Regenerate.
This is OK,
> ! if (! bfd_section_already_linked_table_insert (already_linked_list, sec))
> ! info->callbacks->einfo (_("%F%P: internal error at %D"));
except that it isn't correct to call this an "internal error". (It's
just out of memory.) Use "%F%P: already_linked_table: %E" instead.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2007-07-26 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 2:03 msnyder
2007-07-26 14:22 ` Alan Modra
2007-07-26 23:24 ` msnyder
2007-07-26 23:57 ` Alan Modra [this message]
2007-07-27 1:16 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726235201.GO11649@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).