From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>,
Roland McGrath <roland@redhat.com>,
binutils@sources.redhat.com
Subject: Re: [patch] bfd: Core files with p_filesz < p_memsz (build-id)
Date: Fri, 03 Aug 2007 00:21:00 -0000 [thread overview]
Message-ID: <20070803002103.GA19863@caradoc.them.org> (raw)
In-Reply-To: <20070803001259.GA11213@bubble.grove.modra.org>
On Fri, Aug 03, 2007 at 09:43:00AM +0930, Alan Modra wrote:
> Oh, I see. I was just looking at the split case. I'd say the
> non-split behaviour is a bug. A program header with p_filesz zero and
> p_memsz non-zero really ought to create a bfd section with size equal
> to p_memsz, without SEC_HAS_CONTENTS and SEC_LOAD.
>
> So I think we should apply the following, and possibly on top of this
> do something special for core files.
Yes, I agree. But keep in mind that this patch on its own is going to
lay waste to GDB's core debugging :-) It will now disassemble all
functions as zeroes.
What we really want in GDB is now a bit complicated:
- Prefer data from core file if within p_filesz.
- Prefer data from executable if between p_filesz and p_memsz.
- Show zeroes (rather than read errors) for data between p_filesz
and p_memsz if not present in the executable.
Messy...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-03 0:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 20:16 Jan Kratochvil
2007-07-29 12:30 ` Jan Kratochvil
2007-07-29 15:29 ` Roland McGrath
2007-07-29 18:32 ` Jan Kratochvil
2007-08-01 13:05 ` Alan Modra
2007-08-02 20:03 ` Daniel Jacobowitz
2007-08-03 0:13 ` Alan Modra
2007-08-03 0:21 ` Daniel Jacobowitz [this message]
2007-08-03 2:50 ` Alan Modra
2007-08-06 19:32 ` Daniel Jacobowitz
2007-08-09 16:04 ` Jan Kratochvil
2007-07-30 14:07 ` [resent] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070803002103.GA19863@caradoc.them.org \
--to=drow@false.org \
--cc=binutils@sources.redhat.com \
--cc=jan.kratochvil@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).