public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Greg Schafer <gschafer@zip.com.au>
To: DJ Delorie <dj@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: GNU hash-style compatibility problem on x86_64
Date: Wed, 15 Aug 2007 00:58:00 -0000	[thread overview]
Message-ID: <20070815005828.GA1267@eyo32.local> (raw)
In-Reply-To: <xnlkcdn108.fsf@greed.delorie.com>

On Tue, Aug 14, 2007 at 07:35:03PM -0400, DJ Delorie wrote:
> Greg Schafer <gschafer@zip.com.au> writes:
> > I can understand HJ's response in that there isn't much incentive to fix
> > bugs in an old binutils release, but I was kind of hoping one of the experts
> > here might be able to pinpoint the problem and produce a minimal patch.
> 
> Try this one:
> 
> --- bfd/elf.c       3 Aug 2006 21:41:05 -0000
> +++ bfd/elf.c       3 Aug 2007 01:13:57 -0000
> @@ -1822,6 +1822,7 @@ bfd_section_from_shdr (bfd *abfd, unsign
>      case SHT_FINI_ARRAY:       /* .fini_array section.  */
>      case SHT_PREINIT_ARRAY:    /* .preinit_array section.  */
>      case SHT_GNU_LIBLIST:      /* .gnu.liblist section.  */
> +    case SHT_GNU_HASH:         /* .gnu.hash section.  */
>        return _bfd_elf_make_section_from_shdr (abfd, hdr, name, shindex);
>  
>      case SHT_DYNAMIC:  /* Dynamic linking information.  */
> 

Heh, it works. Thanks a lot!

In addition to the above, I just needed the corresponding define in
include/elf/common.h to make it build.

But it's still a mystery why x86 and ppc don't need this.. oh well.

Regards
Greg

  reply	other threads:[~2007-08-15  0:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14  7:22 Greg Schafer
2007-08-14 12:48 ` H.J. Lu
2007-08-14 12:56   ` Daniel Jacobowitz
2007-08-14 13:02     ` H.J. Lu
2007-08-14 13:07       ` Mike Frysinger
2007-08-14 13:23         ` Jakub Jelinek
2007-08-14 13:31           ` Mike Frysinger
2007-08-14 13:39           ` Daniel Jacobowitz
2007-08-14 22:45     ` Greg Schafer
2007-08-14 23:35       ` DJ Delorie
2007-08-15  0:58         ` Greg Schafer [this message]
2007-08-15  1:01           ` DJ Delorie
2007-08-25  0:05           ` Eric Botcazou
2007-08-29 17:12             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070815005828.GA1267@eyo32.local \
    --to=gschafer@zip.com.au \
    --cc=binutils@sourceware.org \
    --cc=dj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).