From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19900 invoked by alias); 16 Aug 2007 13:49:32 -0000 Received: (qmail 19812 invoked by uid 22791); 16 Aug 2007 13:49:31 -0000 X-Spam-Check-By: sourceware.org Received: from omta04ps.mx.bigpond.com (HELO omta04ps.mx.bigpond.com) (144.140.83.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Aug 2007 13:49:24 +0000 Received: from oaamta08ps.mx.bigpond.com ([58.174.194.22]) by omta04ps.mx.bigpond.com with ESMTP id <20070816134921.VROI1991.omta04ps.mx.bigpond.com@oaamta08ps.mx.bigpond.com> for ; Thu, 16 Aug 2007 13:49:21 +0000 Received: from bubble.grove.modra.org ([58.174.194.22]) by oaamta08ps.mx.bigpond.com with ESMTP id <20070816134921.NNNU7749.oaamta08ps.mx.bigpond.com@bubble.grove.modra.org> for ; Thu, 16 Aug 2007 13:49:21 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id 15ADB33BF62; Thu, 16 Aug 2007 23:19:20 +0930 (CST) Date: Thu, 16 Aug 2007 13:49:00 -0000 From: Alan Modra To: binutils@sourceware.org Subject: Re: XFAIL srec test for powerpc-eabi Message-ID: <20070816134920.GB8269@bubble.grove.modra.org> Mail-Followup-To: binutils@sourceware.org References: <20070802144144.GA24224@caradoc.them.org> <20070802162414.GA29224@caradoc.them.org> <46B314E7.8060302@redhat.com> <20070816061439.GA8269@bubble.grove.modra.org> <20070816113748.GB11637@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070816113748.GB11637@caradoc.them.org> User-Agent: Mutt/1.5.9i X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00245.txt.bz2 On Thu, Aug 16, 2007 at 07:37:48AM -0400, Daniel Jacobowitz wrote: > On Thu, Aug 16, 2007 at 03:44:39PM +0930, Alan Modra wrote: > > I don't see failures on powerpc-linux, except now due to an XPASS.. > > Daniel, this ought to fix the original failure. Would you mind > > checking with your toolchain? > > What compiler version? I believe it will only show up with 4.2 or > later; but I'm guessing about the "or later". I used 4.3.0 20070815, 4.2.0 20061122, and some older versions. > > * ld-srec/srec.exp: Revert 2007-08-03. Instead pass -G 0. > > Works for me. Could you also delete the powerpc-*-eabi XFAIL at the > bottom of the file? Done. This is what I'll commit. * ld-srec/srec.exp: Always pass "-G 0". Remove all powerpc xfails. Index: ld/testsuite/ld-srec/srec.exp =================================================================== RCS file: /cvs/src/src/ld/testsuite/ld-srec/srec.exp,v retrieving revision 1.26 diff -u -p -r1.26 srec.exp --- ld/testsuite/ld-srec/srec.exp 3 Aug 2007 12:53:47 -0000 1.26 +++ ld/testsuite/ld-srec/srec.exp 16 Aug 2007 13:38:03 -0000 @@ -228,8 +228,9 @@ proc run_srec_test { test objs } { global sizeof_headers global host_triplet - # Tell the ELF linker to not do anything clever with .eh_frame. - set flags "--traditional-format" + # Tell the ELF linker to not do anything clever with .eh_frame, + # and not to put anything in small data. + set flags "--traditional-format -G 0" # If the linker script uses SIZEOF_HEADERS, use a -Ttext argument # to force both the normal link and the S-record link to be put in @@ -374,10 +375,6 @@ setup_xfail "thumb-*-pe*" setup_xfail "thumb-*-elf*" setup_xfail "arm*-*-linux*" -# The S-record linker doesn't put common symbols in small data -# the way the ELF linker does. -setup_xfail "powerpc*-*-*" - # The S-record linker doesn't include the .{zda} sections. setup_xfail "v850*-*-elf" @@ -420,7 +417,6 @@ setup_xfail "*-*-aix*" "*-*-xcoff*" setup_xfail "arm*-*-*" setup_xfail "strongarm*-*-*" setup_xfail "thumb-*-*" -setup_xfail "powerpc*-*-eabi*" setup_xfail "v850*-*-elf" setup_xfail "alpha*-*-elf*" "alpha*-*-linux-*" "alpha*-*-gnu*" setup_xfail "alpha*-*-netbsd*" -- Alan Modra Australia Development Lab, IBM