public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Binutils 2.18 available
@ 2007-08-29  3:59 Daniel Jacobowitz
  2007-08-29 11:36 ` Jan Beulich
  2007-08-29 16:43 ` Binutils 2.18 available Dave Korn
  0 siblings, 2 replies; 10+ messages in thread
From: Daniel Jacobowitz @ 2007-08-29  3:59 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

I have placed binutils 2.18 on sourceware.org and ftp.gnu.org in the
usual places, e.g. ftp://ftp.gnu.org/gnu/binutils/.

9d22ee4dafa3a194457caf4706f9cf01  binutils-2.18.tar.bz2
d71b23b4fb91e66802ca2b8f576629f4  binutils-2.18.tar.gz

As usual, thanks to everyone who helped prepare this release.  The
branch remains open for bug fixes; if there are enough to justify it,
I'll prepare a point release in one or two months.

I built and tested the release for a selection of 38 ELF-based
targets; the most popular platforms had no failures, and the others
had only a small assortment of problems.  Well, with one exception:
the ARC disassembler appears to be broken, which messes up the gas
testsuite awfully.

-- 
Daniel Jacobowitz
CodeSourcery

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Binutils 2.18 available
  2007-08-29  3:59 Binutils 2.18 available Daniel Jacobowitz
@ 2007-08-29 11:36 ` Jan Beulich
  2007-08-29 14:12   ` Daniel Jacobowitz
  2007-08-29 16:43 ` Binutils 2.18 available Dave Korn
  1 sibling, 1 reply; 10+ messages in thread
From: Jan Beulich @ 2007-08-29 11:36 UTC (permalink / raw)
  To: Daniel Jacobowitz, binutils

Thanks, Daniel. Nevertheless, a question: is it known that on (at least) i386-linux
ld's selective[456] tests produce an assertion failure, causing two unexpected
failures (which seems not really nice for a release and a pretty important
architecture):

gcc  -B/home/jbeulich/build/binutils/2.18-base/ld/tmpdir/gas/ -I/usr/local/src/binutils-2.18/ld/testsuite/ld-selective -g -O2   -L/home/jbeulich/build/binutils/2.18-base/./ld -w -O -ffunction-sections -fdata-sections -fvtable-gc -fno-exceptions -fno-rtti -c /usr/local/src/binutils-2.18/ld/testsuite/ld-selective/3.cc -o tmpdir/3.o
/home/jbeulich/build/binutils/2.18-base/ld/ld-new  -o tmpdir/3.x --gc-sections -Bstatic  tmpdir/3.o
/home/jbeulich/build/binutils/2.18-base/ld/ld-new: BFD (GNU Binutils) 2.18 assertion fail /usr/local/src/binutils-2.18/bfd/elf32-i386.c:1273
FAIL: selective4
gcc  -B/home/jbeulich/build/binutils/2.18-base/ld/tmpdir/gas/ -I/usr/local/src/binutils-2.18/ld/testsuite/ld-selective -g -O2   -L/home/jbeulich/build/binutils/2.18-base/./ld -w -O -ffunction-sections -fdata-sections -fvtable-gc -fno-exceptions -fno-rtti -c /usr/local/src/binutils-2.18/ld/testsuite/ld-selective/4.cc -o tmpdir/4.o
/home/jbeulich/build/binutils/2.18-base/ld/ld-new  -o tmpdir/4.x --gc-sections -Bstatic  tmpdir/4.o
/home/jbeulich/build/binutils/2.18-base/ld/ld-new: BFD (GNU Binutils) 2.18 assertion fail /usr/local/src/binutils-2.18/bfd/elf32-i386.c:1273
FAIL: selective5
gcc  -B/home/jbeulich/build/binutils/2.18-base/ld/tmpdir/gas/ -I/usr/local/src/binutils-2.18/ld/testsuite/ld-selective -g -O2   -L/home/jbeulich/build/binutils/2.18-base/./ld -w -O -ffunction-sections -fdata-sections -fvtable-gc -fno-exceptions -fno-rtti -c /usr/local/src/binutils-2.18/ld/testsuite/ld-selective/5.cc -o tmpdir/5.o
/home/jbeulich/build/binutils/2.18-base/ld/ld-new  -o tmpdir/5.x --gc-sections -Bstatic  tmpdir/5.o
/home/jbeulich/build/binutils/2.18-base/ld/ld-new: BFD (GNU Binutils) 2.18 assertion fail /usr/local/src/binutils-2.18/bfd/elf32-i386.c:1273
XFAIL: selective6

Jan

>>> Daniel Jacobowitz <drow@false.org> 29.08.07 00:08 >>>
I have placed binutils 2.18 on sourceware.org and ftp.gnu.org in the
usual places, e.g. ftp://ftp.gnu.org/gnu/binutils/.

9d22ee4dafa3a194457caf4706f9cf01  binutils-2.18.tar.bz2
d71b23b4fb91e66802ca2b8f576629f4  binutils-2.18.tar.gz

As usual, thanks to everyone who helped prepare this release.  The
branch remains open for bug fixes; if there are enough to justify it,
I'll prepare a point release in one or two months.

I built and tested the release for a selection of 38 ELF-based
targets; the most popular platforms had no failures, and the others
had only a small assortment of problems.  Well, with one exception:
the ARC disassembler appears to be broken, which messes up the gas
testsuite awfully.

-- 
Daniel Jacobowitz
CodeSourcery

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Binutils 2.18 available
  2007-08-29 11:36 ` Jan Beulich
@ 2007-08-29 14:12   ` Daniel Jacobowitz
  2007-08-29 16:35     ` Jan Beulich
  0 siblings, 1 reply; 10+ messages in thread
From: Daniel Jacobowitz @ 2007-08-29 14:12 UTC (permalink / raw)
  To: Jan Beulich; +Cc: binutils

On Wed, Aug 29, 2007 at 09:19:43AM +0100, Jan Beulich wrote:
> Thanks, Daniel. Nevertheless, a question: is it known that on (at least) i386-linux
> ld's selective[456] tests produce an assertion failure, causing two unexpected
> failures (which seems not really nice for a release and a pretty important
> architecture):

They do not for me.  However, they are somewhat sensitive to the
compiler in use.

> gcc  -B/home/jbeulich/build/binutils/2.18-base/ld/tmpdir/gas/ -I/usr/local/src/binutils-2.18/ld/testsuite/ld-selective -g -O2   -L/home/jbeulich/build/binutils/2.18-base/./ld -w -O -ffunction-sections -fdata-sections -fvtable-gc -fno-exceptions -fno-rtti -c /usr/local/src/binutils-2.18/ld/testsuite/ld-selective/3.cc -o tmpdir/3.o
> /home/jbeulich/build/binutils/2.18-base/ld/ld-new  -o tmpdir/3.x --gc-sections -Bstatic  tmpdir/3.o
> /home/jbeulich/build/binutils/2.18-base/ld/ld-new: BFD (GNU Binutils) 2.18 assertion fail /usr/local/src/binutils-2.18/bfd/elf32-i386.c:1273

          /* This relocation describes the C++ object vtable
	  hierarchy.
             Reconstruct it for later use during GC.  */
        case R_386_GNU_VTINHERIT:
          BFD_ASSERT (h != NULL);
          if (h != NULL
              && !bfd_elf_gc_record_vtinherit (abfd, sec, h,
	      rel->r_offset))
            return FALSE;
          break;

How on earth did you get an R_386_GNU_VTINHERIT?  You must be using a
much older compiler than I am.

-- 
Daniel Jacobowitz
CodeSourcery

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Binutils 2.18 available
  2007-08-29 14:12   ` Daniel Jacobowitz
@ 2007-08-29 16:35     ` Jan Beulich
  2007-08-29 16:45       ` Daniel Jacobowitz
  0 siblings, 1 reply; 10+ messages in thread
From: Jan Beulich @ 2007-08-29 16:35 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: binutils

>How on earth did you get an R_386_GNU_VTINHERIT?  You must be using a
>much older compiler than I am.

gcc 3.3.1 (SuSE 9.0) - are 3.3.x compilers not supported anymore?

Jan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: Binutils 2.18 available
  2007-08-29  3:59 Binutils 2.18 available Daniel Jacobowitz
  2007-08-29 11:36 ` Jan Beulich
@ 2007-08-29 16:43 ` Dave Korn
  1 sibling, 0 replies; 10+ messages in thread
From: Dave Korn @ 2007-08-29 16:43 UTC (permalink / raw)
  To: 'Daniel Jacobowitz', binutils

On 28 August 2007 23:08, Daniel Jacobowitz wrote:

> I have placed binutils 2.18 on sourceware.org and ftp.gnu.org in the
> usual places, e.g. ftp://ftp.gnu.org/gnu/binutils/.
> 
> 9d22ee4dafa3a194457caf4706f9cf01  binutils-2.18.tar.bz2
> d71b23b4fb91e66802ca2b8f576629f4  binutils-2.18.tar.gz
> 
> As usual, thanks to everyone who helped prepare this release.  The
> branch remains open for bug fixes; if there are enough to justify it,
> I'll prepare a point release in one or two months.
> 
> I built and tested the release for a selection of 38 ELF-based
> targets; the most popular platforms had no failures, and the others
> had only a small assortment of problems.  Well, with one exception:
> the ARC disassembler appears to be broken, which messes up the gas
> testsuite awfully.

Here's the results from a run on i686-pc-cygwin, FTR:

Test Run By dk on Wed Aug 29 14:54:34 2007
Native configuration is i686-pc-cygwin

		=== binutils tests ===

Schedule of variations:
    unix

Running target unix
Using /artimi/tools/cygwin/share/dejagnu/baseboards/unix.exp as board
description file for target.
Using /artimi/tools/cygwin/share/dejagnu/config/unix.exp as generic interface
file for target.
Using /tmp/binutils-2.18/binutils/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/ar.exp ...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/arm/objdump.exp ...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/dlltool.exp ...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/hppa/objdump.exp
...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/m68k/objdump.exp
...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/nm.exp ...
Version /tmp/binbuild/binutils/nm-new 2.18
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/objcopy.exp ...
Version /tmp/binbuild/binutils/objcopy 2.18
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/objdump.exp ...
Version /tmp/binbuild/binutils/objdump 2.18
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/readelf.exp ...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/size.exp ...
Version /tmp/binbuild/binutils/size 2.18
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/vax/objdump.exp ...
Running /tmp/binutils-2.18/binutils/testsuite/binutils-all/windres/windres.exp
...

		=== binutils Summary ===

# of expected passes		86
# of expected failures		1
# of unsupported tests		1


Test Run By dk on Wed Aug 29 14:55:19 2007
Native configuration is i686-pc-cygwin

		=== gas tests ===

Schedule of variations:
    unix

Running target unix
Using /artimi/tools/cygwin/share/dejagnu/baseboards/unix.exp as board
description file for target.
Using /artimi/tools/cygwin/share/dejagnu/config/unix.exp as generic interface
file for target.
Using /tmp/binutils-2.18/gas/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /tmp/binutils-2.18/gas/testsuite/gas/all/gas.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/alpha/alpha.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/arc/arc.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/arc/warn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/arm/arm.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/bfin/bfin.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/cfi/cfi.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/cr16/cr16.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/cris/cris.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/crx/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/d10v/d10v.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/d30v/d30.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/dlx/alltests.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/elf/elf.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/fr30/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/fr30/fr30.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/frv/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/h8300-coff.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/h8300-elf.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/h8300.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t01_mov.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t02_mova.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t03_add.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t04_sub.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t05_cmp.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t06_ari2.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t07_ari3.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t08_or.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t09_xor.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t10_and.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t11_logs.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t12_bit.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/h8300/t13_otr.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/hppa/basic/basic.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/hppa/parse/parse.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/hppa/reloc/reloc.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/hppa/unsorted/unsorted.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/i386/i386.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/i860/i860.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/ia64/ia64.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/ieee-fp/x930509a.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/iq2000/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/iq2000/load-hazards.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/iq2000/odd-ldw.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/iq2000/odd-sdw.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/iq2000/yield.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/lns/lns.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/error.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/m32r.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/m32r2.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/m32rx.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/pic.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m32r/rel32.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m68hc11/m68hc11.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m68k-coff/gas.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/m68k/all.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/macros/macros.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/maxq10/maxq10.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/maxq20/maxq20.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mcore/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mep/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mep/complex-relocs.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mips/mips.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mmix/mmix-err.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mmix/mmix-list.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mmix/mmix.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mn10200/basic.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mn10300/basic.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mri/mri.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/msp430/msp430.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mt/errors.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mt/mt.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/mt/relocs.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/openrisc/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/pdp11/pdp11.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/pj/pj.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/ppc/aix.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/ppc/ppc.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/s390/s390.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/score/relax.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sh/arch/arch.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sh/basic.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sh/err.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sh/sh64/err.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sh/sh64/sh64.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sparc-solaris/addend.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sparc-solaris/gas.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sparc/mismatch.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sparc/sparc.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/sun4/addend.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/symver/symver.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/tic4x/tic4x.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/tic54x/tic54x.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/v850/basic.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/vax/vax.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/xc16x/xc16x.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/xstormy16/allinsn.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/xtensa/all.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/z80/z80.exp ...
Running /tmp/binutils-2.18/gas/testsuite/gas/z8k/z8k.exp ...

		=== gas Summary ===

# of expected passes		141
# of expected failures		1
../as-new 2.18


WARNING: Couldn't find the global config file.
WARNING: Couldn't find tool init file
Test Run By dk on Wed Aug 29 14:56:22 2007
Native configuration is i686-pc-cygwin

		=== ld tests ===

Schedule of variations:
    unix

Running target unix
Using /artimi/tools/cygwin/share/dejagnu/baseboards/unix.exp as board
description file for target.
Using /artimi/tools/cygwin/share/dejagnu/config/unix.exp as generic interface
file for target.
Using /tmp/binutils-2.18/ld/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /tmp/binutils-2.18/ld/testsuite/ld-alpha/alpha.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-arm/arm-elf.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-auto-import/auto-import.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-bootstrap/bootstrap.exp ...
FAIL: bootstrap
FAIL: bootstrap with --static
Running /tmp/binutils-2.18/ld/testsuite/ld-cdtest/cdtest.exp ...
FAIL: cdtest with -Ur
Running /tmp/binutils-2.18/ld/testsuite/ld-checks/checks.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-cris/cris.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-crx/crx.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-cygwin/exe-export.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-d10v/d10v.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-discard/discard.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/binutils.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/dwarf.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/elf.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/exclude.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/frame.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/sec64k.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/shared.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/tls_common.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elf/wrap.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elfcomm/elfcomm.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elfvers/vers.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elfvsb/elfvsb.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-elfweak/elfweak.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-fastcall/fastcall.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-frv/fdpic.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-frv/frv-elf.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-frv/tls.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-h8300/h8300.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-i386/i386.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-ia64/ia64.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-libs/libs.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-linkonce/linkonce.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-m68hc11/m68hc11.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-m68k/m68k.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-maxq/maxq.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-mep/mep.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-mips-elf/mips-elf-flags.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-mips-elf/mips-elf.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-mmix/mmix.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-pe/direct.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-pe/pe.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-pie/pie.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-powerpc/powerpc.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-s390/s390.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/align.exp ...
XPASS: align1
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/alignof.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/assert.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/crossref.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/data.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/default-script.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/defined.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/dynamic-sections.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/empty-address.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/empty-aligned.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/empty-orphan.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/expr.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/extern.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/map-address.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/overlay-size.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/phdrs.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/phdrs2.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/provide.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/script.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/size.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/sizeof.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/sort.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-scripts/weak.exp ...
FAIL: weak symbols
Running /tmp/binutils-2.18/ld/testsuite/ld-selective/sel-dump.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-selective/selective.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/arch/arch.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/rd-sh.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/sh-vxworks.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/sh.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/sh64/rd-sh64.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/sh64/relax.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/sh64/relfail.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sh/sh64/sh64.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-shared/shared.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-sparc/sparc.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-spu/spu.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-srec/srec.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-undefined/undefined.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-undefined/weak-undef.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-v850/v850.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-versados/versados.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-vxworks/vxworks.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-x86-64/x86-64.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-xc16x/xc16x.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-xstormy16/xstormy16.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-xtensa/coalesce.exp ...
Running /tmp/binutils-2.18/ld/testsuite/ld-xtensa/lcall.exp ...

		=== ld Summary ===

# of expected passes		59
# of unexpected failures	4
# of unexpected successes	1
# of expected failures		3
# of unsupported tests		1
/tmp/binbuild/ld/ld-new 2.18

./test-demangle < /tmp/binutils-2.18/libiberty/testsuite/demangle-expected
./test-demangle: 765 tests, 0 failures
./test-pexecute
test-pexecute:273: abort failed
./test-expandargv
PASS: test-expandargv-0.
PASS: test-expandargv-1.
PASS: test-expandargv-2.
PASS: test-expandargv-3.



  I think the "FAIL: bootstrap" might be relatively new; I couldn't find it in
a quick browse through my inbox for Christian's most recent testresults.



    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Binutils 2.18 available
  2007-08-29 16:35     ` Jan Beulich
@ 2007-08-29 16:45       ` Daniel Jacobowitz
  2007-08-30 11:17         ` Jan Beulich
  2007-09-21 11:03         ` (was Re: Binutils 2.18 available) Jan Beulich
  0 siblings, 2 replies; 10+ messages in thread
From: Daniel Jacobowitz @ 2007-08-29 16:45 UTC (permalink / raw)
  To: Jan Beulich; +Cc: binutils

On Wed, Aug 29, 2007 at 04:32:52PM +0100, Jan Beulich wrote:
> >How on earth did you get an R_386_GNU_VTINHERIT?  You must be using a
> >much older compiler than I am.
> 
> gcc 3.3.1 (SuSE 9.0) - are 3.3.x compilers not supported anymore?

Of course they are.  I don't know if -fvtable-gc is, though.  I know
that recent GCC's no longer emit .vtable_inherit, so it is likely that
the support is starting to rot.

     # Starting with 3.4.0, -fvtable-gc is no longer supported and thus
     # the functionality we try to test for cannot be expected to work.

selective4 and selective5 pass for me on x86_64-linux with GCC 3.3,
FWIW.

-- 
Daniel Jacobowitz
CodeSourcery

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Binutils 2.18 available
  2007-08-29 16:45       ` Daniel Jacobowitz
@ 2007-08-30 11:17         ` Jan Beulich
  2007-09-21 11:03         ` (was Re: Binutils 2.18 available) Jan Beulich
  1 sibling, 0 replies; 10+ messages in thread
From: Jan Beulich @ 2007-08-30 11:17 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: binutils

>>> Daniel Jacobowitz <drow@false.org> 29.08.07 18:35 >>>
>On Wed, Aug 29, 2007 at 04:32:52PM +0100, Jan Beulich wrote:
>> >How on earth did you get an R_386_GNU_VTINHERIT?  You must be using a
>> >much older compiler than I am.
>> 
>> gcc 3.3.1 (SuSE 9.0) - are 3.3.x compilers not supported anymore?
>
>Of course they are.  I don't know if -fvtable-gc is, though.  I know
>that recent GCC's no longer emit .vtable_inherit, so it is likely that
>the support is starting to rot.
>
>     # Starting with 3.4.0, -fvtable-gc is no longer supported and thus
>     # the functionality we try to test for cannot be expected to work.

Okay, that means I may have to dig into this.

>selective4 and selective5 pass for me on x86_64-linux with GCC 3.3,
>FWIW.

So do they for me, with gcc 3.3.3 (SLES9).

Jan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* (was Re: Binutils 2.18 available)
  2007-08-29 16:45       ` Daniel Jacobowitz
  2007-08-30 11:17         ` Jan Beulich
@ 2007-09-21 11:03         ` Jan Beulich
  2007-09-26 11:57           ` [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 " Jan Beulich
  1 sibling, 1 reply; 10+ messages in thread
From: Jan Beulich @ 2007-09-21 11:03 UTC (permalink / raw)
  To: H. J. Lu; +Cc: Daniel Jacobowitz, msnyder, binutils

Your request to apply the same change to R_386_GNU_VTINHERIT as was
suggested by Michael for handling R_386_GNU_VTENTRY (in
http://sourceware.org/ml/binutils/2007-07/msg00438.html) was apparently
wrong: Looking at the two functions bfd_elf_gc_record_vtinherit() and
bfd_elf_gc_record_vtentry() reveals the significant difference that the
former is prepared to deal with h being NULL, while the latter isn't. Beyond
requesting to revert that part of the patch I'm also curious to understand
why the same change wasn't applied to all other affected instances in
various elf<width>-<arch>.c files (which accounts for the odd situation
that, as described in Daniel's response, mentioned tests succeed for x86-64
whereas they fail for i386).

Jan

>>> Daniel Jacobowitz <drow@false.org> 29.08.07 18:35 >>>
On Wed, Aug 29, 2007 at 04:32:52PM +0100, Jan Beulich wrote:
> >How on earth did you get an R_386_GNU_VTINHERIT?  You must be using a
> >much older compiler than I am.
> 
> gcc 3.3.1 (SuSE 9.0) - are 3.3.x compilers not supported anymore?

Of course they are.  I don't know if -fvtable-gc is, though.  I know
that recent GCC's no longer emit .vtable_inherit, so it is likely that
the support is starting to rot.

     # Starting with 3.4.0, -fvtable-gc is no longer supported and thus
     # the functionality we try to test for cannot be expected to work.

selective4 and selective5 pass for me on x86_64-linux with GCC 3.3,
FWIW.

-- 
Daniel Jacobowitz
CodeSourcery

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 (was  Re: Binutils 2.18 available)
  2007-09-21 11:03         ` (was Re: Binutils 2.18 available) Jan Beulich
@ 2007-09-26 11:57           ` Jan Beulich
  2007-09-26 16:48             ` Alan Modra
  0 siblings, 1 reply; 10+ messages in thread
From: Jan Beulich @ 2007-09-26 11:57 UTC (permalink / raw)
  To: binutils; +Cc: Daniel Jacobowitz, H. J. Lu, msnyder

>>> "Jan Beulich" <jbeulich@novell.com> 21.09.07 10:39 >>>
>Your request to apply the same change to R_386_GNU_VTINHERIT as was
>suggested by Michael for handling R_386_GNU_VTENTRY (in
>http://sourceware.org/ml/binutils/2007-07/msg00438.html) was apparently
>wrong: Looking at the two functions bfd_elf_gc_record_vtinherit() and
>bfd_elf_gc_record_vtentry() reveals the significant difference that the
>former is prepared to deal with h being NULL, while the latter isn't. Beyond
>requesting to revert that part of the patch I'm also curious to understand
>why the same change wasn't applied to all other affected instances in
>various elf<width>-<arch>.c files (which accounts for the odd situation
>that, as described in Daniel's response, mentioned tests succeed for x86-64
>whereas they fail for i386).
>
>Jan
>
>>>> Daniel Jacobowitz <drow@false.org> 29.08.07 18:35 >>>
>On Wed, Aug 29, 2007 at 04:32:52PM +0100, Jan Beulich wrote:
>> >How on earth did you get an R_386_GNU_VTINHERIT?  You must be using a
>> >much older compiler than I am.
>> 
>> gcc 3.3.1 (SuSE 9.0) - are 3.3.x compilers not supported anymore?
>
>Of course they are.  I don't know if -fvtable-gc is, though.  I know
>that recent GCC's no longer emit .vtable_inherit, so it is likely that
>the support is starting to rot.
>
>     # Starting with 3.4.0, -fvtable-gc is no longer supported and thus
>     # the functionality we try to test for cannot be expected to work.
>
>selective4 and selective5 pass for me on x86_64-linux with GCC 3.3,
>FWIW.

Built (with --enable-targets=all) and tested on x86_64-unknown-linux-gnu.

bfd/
2007-09-26  Jan Beulich  <jbeulich@novell.com>

	* elf32-i386.c (elf_i386_check_relocs): Revert NULL pointer
	check for R_386_GNU_VTINHERIT.
	* elf-m10300.c (mn10300_elf_check_relocs): Check for NULL
	pointer for R_xxx_GNU_VTENTRY.
	* elf32-arm.c (elf32_arm_check_relocs): Likewise.
	* elf32-bfin.c (bfin_check_relocs): Likewise.
	(bfinfdpic_check_relocs): Likewise.
	* elf32-cris.c (cris_elf_check_relocs): Likewise.
	* elf32-d10v.c (elf32_d10v_check_relocs): Likewise.
	* elf32-dlx.c (elf32_dlx_check_relocs): Likewise.
	* elf32-fr30.c (fr30_elf_check_relocs): Likewise.
	* elf32-frv.c (elf32_frv_check_relocs): Likewise.
	* elf32-iq2000.c (iq2000_elf_check_relocs): Likewise.
	* elf32-m32r.c (m32r_elf_check_relocs): Likewise.
	* elf32-m68hc1x.c (elf32_m68hc11_check_relocs): Likewise.
	* elf32-m68k.c (elf_m68k_check_relocs): Likewise.
	* elf32-mcore.c (mcore_elf_check_relocs): Likewise.
	* elf32-openrisc.c (openrisc_elf_check_relocs): Likewise.
	* elf32-ppc.c (ppc_elf_check_relocs): Likewise.
	* elf32-s390.c (elf_s390_check_relocs): Likewise.
	* elf32-score.c (_bfd_score_elf_check_relocs): Likewise.
	* elf32-sh.c (sh_elf_check_relocs): Likewise.
	* elf32-v850.c (v850_elf_check_relocs): Likewise.
	* elf32-vax.c (elf_vax_check_relocs): Likewise.
	* elf32-xstormy16.c (xstormy16_elf_check_relocs): Likewise.
	* elf32-xtensa.c (elf_xtensa_check_relocs): Likewise.
	* elf64-mmix.c (mmix_elf_check_relocs): Likewise.
	* elf64-ppc.c (ppc64_elf_check_relocs): Likewise.
	* elf64-s390.c (elf_s390_check_relocs): Likewise.
	* elf64-sh64.c (sh_elf64_check_relocs): Likewise.
	* elf64-x86-64.c (elf64_x86_64_check_relocs): Likewise.
	* elfxx-mips.c (_bfd_mips_elf_check_relocs): Likewise.
	* elfxx-sparc.c (_bfd_sparc_elf_check_relocs): Likewise.
	* elf32-hppa.c (elf32_hppa_check_relocs): Likewise. Also handle
	NULL pointer case for R_PARISC_GNU_VTINHERIT.

--- 2007-09-25/bfd/elf-m10300.c	2007-08-22 11:01:41.000000000 +0200
+++ 2007-09-25/bfd/elf-m10300.c	2007-09-26 00:00:00.000000000 +0200
@@ -758,7 +758,9 @@ mn10300_elf_check_relocs (abfd, info, se
 	/* This relocation describes which C++ vtable entries are actually
 	   used.  Record for later use during GC.  */
 	case R_MN10300_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 	case R_MN10300_GOT32:
--- 2007-09-25/bfd/elf32-arm.c	2007-09-11 12:23:30.000000000 +0200
+++ 2007-09-25/bfd/elf32-arm.c	2007-09-26 00:00:00.000000000 +0200
@@ -7795,7 +7795,9 @@ elf32_arm_check_relocs (bfd *abfd, struc
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_ARM_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-bfin.c	2007-09-11 12:23:30.000000000 +0200
+++ 2007-09-25/bfd/elf32-bfin.c	2007-09-26 00:00:00.000000000 +0200
@@ -1979,7 +1979,9 @@ bfin_check_relocs (bfd * abfd,
         /* This relocation describes which C++ vtable entries
            are actually used.  Record for later use during GC.  */
         case R_BFIN_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 
@@ -4671,7 +4673,9 @@ bfinfdpic_check_relocs (bfd *abfd, struc
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_BFIN_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 
--- 2007-09-25/bfd/elf32-cris.c	2007-08-22 11:01:41.000000000 +0200
+++ 2007-09-25/bfd/elf32-cris.c	2007-09-26 00:00:00.000000000 +0200
@@ -2853,7 +2853,9 @@ cris_elf_check_relocs (abfd, info, sec, 
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_CRIS_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 
--- 2007-09-25/bfd/elf32-d10v.c	2007-08-22 11:01:41.000000000 +0200
+++ 2007-09-25/bfd/elf32-d10v.c	2007-09-26 00:00:00.000000000 +0200
@@ -304,7 +304,9 @@ elf32_d10v_check_relocs (bfd *abfd,
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_D10V_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-dlx.c	2007-08-22 11:01:41.000000000 +0200
+++ 2007-09-25/bfd/elf32-dlx.c	2007-09-26 00:00:00.000000000 +0200
@@ -470,7 +470,9 @@ elf32_dlx_check_relocs (bfd *abfd,
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_DLX_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-fr30.c	2007-08-22 11:01:41.000000000 +0200
+++ 2007-09-25/bfd/elf32-fr30.c	2007-09-26 00:00:00.000000000 +0200
@@ -716,7 +716,9 @@ fr30_elf_check_relocs (abfd, info, sec, 
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_FR30_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-frv.c	2007-08-22 11:01:41.000000000 +0200
+++ 2007-09-25/bfd/elf32-frv.c	2007-09-26 00:00:00.000000000 +0200
@@ -6400,7 +6400,9 @@ elf32_frv_check_relocs (abfd, info, sec,
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_FRV_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 
--- 2007-09-25/bfd/elf32-hppa.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-hppa.c	2007-09-26 00:00:00.000000000 +0200
@@ -1271,14 +1271,18 @@ elf32_hppa_check_relocs (bfd *abfd,
 	  /* This relocation describes the C++ object vtable hierarchy.
 	     Reconstruct it for later use during GC.  */
 	case R_PARISC_GNU_VTINHERIT:
-	  if (!bfd_elf_gc_record_vtinherit (abfd, sec, &hh->eh, rela->r_offset))
+	  if (!bfd_elf_gc_record_vtinherit (abfd, sec,
+					    hh != NULL ? &hh->eh : NULL,
+					    rela->r_offset))
 	    return FALSE;
 	  continue;
 
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_PARISC_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, &hh->eh, rela->r_addend))
+	  BFD_ASSERT (hh != NULL);
+	  if (hh != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, &hh->eh, rela->r_addend))
 	    return FALSE;
 	  continue;
 
--- 2007-09-25/bfd/elf32-i386.c	2007-09-11 17:24:45.000000000 +0200
+++ 2007-09-25/bfd/elf32-i386.c	2007-09-21 10:41:08.000000000 +0200
@@ -1544,9 +1544,7 @@ elf_i386_check_relocs (bfd *abfd,
 	  /* This relocation describes the C++ object vtable hierarchy.
 	     Reconstruct it for later use during GC.  */
 	case R_386_GNU_VTINHERIT:
-	  BFD_ASSERT (h != NULL);
-	  if (h != NULL
-	      && !bfd_elf_gc_record_vtinherit (abfd, sec, h, rel->r_offset))
+	  if (!bfd_elf_gc_record_vtinherit (abfd, sec, h, rel->r_offset))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-iq2000.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-iq2000.c	2007-09-26 00:00:00.000000000 +0200
@@ -467,7 +467,9 @@ iq2000_elf_check_relocs (bfd *abfd,
 	  /* This relocation describes which C++ vtable entries
 	     are actually used.  Record for later use during GC.  */
 	case R_IQ2000_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-m32r.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-m32r.c	2007-09-26 00:00:00.000000000 +0200
@@ -4036,11 +4036,15 @@ m32r_elf_check_relocs (bfd *abfd,
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_M32R_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
             return FALSE;
           break;
         case R_M32R_RELA_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-m68hc1x.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-m68hc1x.c	2007-09-26 00:00:00.000000000 +0200
@@ -865,7 +865,9 @@ elf32_m68hc11_check_relocs (bfd *abfd, s
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_M68HC11_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-m68k.c	2007-09-12 09:30:46.000000000 +0200
+++ 2007-09-25/bfd/elf32-m68k.c	2007-09-26 00:00:00.000000000 +0200
@@ -1042,7 +1042,9 @@ elf_m68k_check_relocs (abfd, info, sec, 
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_68K_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-mcore.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-mcore.c	2007-09-26 00:00:00.000000000 +0200
@@ -638,7 +638,9 @@ mcore_elf_check_relocs (bfd * abfd,
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_MCORE_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
         }
--- 2007-09-25/bfd/elf32-openrisc.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-openrisc.c	2007-09-26 00:00:00.000000000 +0200
@@ -511,7 +511,9 @@ openrisc_elf_check_relocs (bfd *abfd,
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_OPENRISC_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 	}
--- 2007-09-25/bfd/elf32-ppc.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-ppc.c	2007-09-26 00:00:00.000000000 +0200
@@ -3376,7 +3376,9 @@ ppc_elf_check_relocs (bfd *abfd,
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_PPC_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-s390.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-s390.c	2007-09-26 00:00:00.000000000 +0200
@@ -1376,7 +1376,9 @@ elf_s390_check_relocs (abfd, info, sec, 
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_390_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-score.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-score.c	2007-09-26 00:00:00.000000000 +0200
@@ -2683,7 +2683,9 @@ _bfd_score_elf_check_relocs (bfd *abfd,
           /* This relocation describes which C++ vtable entries are actually
              used.  Record for later use during GC.  */
         case R_SCORE_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
             return FALSE;
           break;
         default:
--- 2007-09-25/bfd/elf32-sh.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-sh.c	2007-09-26 00:00:00.000000000 +0200
@@ -4959,7 +4959,9 @@ sh_elf_check_relocs (bfd *abfd, struct b
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_SH_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-v850.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-v850.c	2007-09-26 00:00:00.000000000 +0200
@@ -116,7 +116,9 @@ v850_elf_check_relocs (bfd *abfd,
         /* This relocation describes which C++ vtable entries
 	   are actually used.  Record for later use during GC.  */
         case R_V850_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 
--- 2007-09-25/bfd/elf32-vax.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-vax.c	2007-09-26 00:00:00.000000000 +0200
@@ -821,7 +821,9 @@ elf_vax_check_relocs (bfd *abfd, struct 
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_VAX_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf32-xstormy16.c	2007-08-22 11:01:42.000000000 +0200
+++ 2007-09-25/bfd/elf32-xstormy16.c	2007-09-26 00:00:00.000000000 +0200
@@ -512,7 +512,9 @@ xstormy16_elf_check_relocs (bfd *abfd,
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
         case R_XSTORMY16_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 	}
--- 2007-09-25/bfd/elf32-xtensa.c	2007-09-11 12:23:30.000000000 +0200
+++ 2007-09-25/bfd/elf32-xtensa.c	2007-09-26 00:00:00.000000000 +0200
@@ -944,7 +944,9 @@ elf_xtensa_check_relocs (bfd *abfd,
 	case R_XTENSA_GNU_VTENTRY:
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf64-mmix.c	2007-08-22 11:01:43.000000000 +0200
+++ 2007-09-25/bfd/elf64-mmix.c	2007-09-26 00:00:00.000000000 +0200
@@ -2029,7 +2029,9 @@ mmix_elf_check_relocs (abfd, info, sec, 
         /* This relocation describes which C++ vtable entries are actually
            used.  Record for later use during GC.  */
         case R_MMIX_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 	}
--- 2007-09-25/bfd/elf64-ppc.c	2007-09-11 12:23:30.000000000 +0200
+++ 2007-09-25/bfd/elf64-ppc.c	2007-09-26 00:00:00.000000000 +0200
@@ -4619,7 +4619,9 @@ ppc64_elf_check_relocs (bfd *abfd, struc
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_PPC64_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf64-s390.c	2007-08-22 11:01:43.000000000 +0200
+++ 2007-09-25/bfd/elf64-s390.c	2007-09-26 00:00:00.000000000 +0200
@@ -1344,7 +1344,9 @@ elf_s390_check_relocs (abfd, info, sec, 
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_390_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elf64-sh64.c	2007-08-22 11:01:43.000000000 +0200
+++ 2007-09-25/bfd/elf64-sh64.c	2007-09-26 00:00:00.000000000 +0200
@@ -2508,7 +2508,9 @@ sh_elf64_check_relocs (bfd *abfd, struct
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
         case R_SH_GNU_VTENTRY:
-          if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+          BFD_ASSERT (h != NULL);
+          if (h != NULL
+              && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
             return FALSE;
           break;
 
--- 2007-09-25/bfd/elf64-x86-64.c	2007-09-11 17:24:52.000000000 +0200
+++ 2007-09-25/bfd/elf64-x86-64.c	2007-09-21 10:41:39.000000000 +0200
@@ -1378,7 +1378,9 @@ elf64_x86_64_check_relocs (bfd *abfd, st
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_X86_64_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elfxx-mips.c	2007-09-25 16:27:40.000000000 +0200
+++ 2007-09-25/bfd/elfxx-mips.c	2007-09-26 00:00:00.000000000 +0200
@@ -6709,7 +6709,9 @@ _bfd_mips_elf_check_relocs (bfd *abfd, s
 	  /* This relocation describes which C++ vtable entries are actually
 	     used.  Record for later use during GC.  */
 	case R_MIPS_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_offset))
 	    return FALSE;
 	  break;
 
--- 2007-09-25/bfd/elfxx-sparc.c	2007-08-22 11:01:43.000000000 +0200
+++ 2007-09-25/bfd/elfxx-sparc.c	2007-09-26 00:00:00.000000000 +0200
@@ -1516,7 +1516,9 @@ _bfd_sparc_elf_check_relocs (bfd *abfd, 
 	  break;
 
 	case R_SPARC_GNU_VTENTRY:
-	  if (!bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
+	  BFD_ASSERT (h != NULL);
+	  if (h != NULL
+	      && !bfd_elf_gc_record_vtentry (abfd, sec, h, rel->r_addend))
 	    return FALSE;
 	  break;
 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 (was  Re: Binutils 2.18 available)
  2007-09-26 11:57           ` [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 " Jan Beulich
@ 2007-09-26 16:48             ` Alan Modra
  0 siblings, 0 replies; 10+ messages in thread
From: Alan Modra @ 2007-09-26 16:48 UTC (permalink / raw)
  To: Jan Beulich; +Cc: binutils

On Wed, Sep 26, 2007 at 11:33:46AM +0100, Jan Beulich wrote:
> 	* elf32-i386.c (elf_i386_check_relocs): Revert NULL pointer
> 	check for R_386_GNU_VTINHERIT.
> 	* elf-m10300.c (mn10300_elf_check_relocs): Check for NULL
> 	pointer for R_xxx_GNU_VTENTRY.
> 	* elf32-arm.c (elf32_arm_check_relocs): Likewise.
> 	* elf32-bfin.c (bfin_check_relocs): Likewise.
> 	(bfinfdpic_check_relocs): Likewise.
> 	* elf32-cris.c (cris_elf_check_relocs): Likewise.
> 	* elf32-d10v.c (elf32_d10v_check_relocs): Likewise.
> 	* elf32-dlx.c (elf32_dlx_check_relocs): Likewise.
> 	* elf32-fr30.c (fr30_elf_check_relocs): Likewise.
> 	* elf32-frv.c (elf32_frv_check_relocs): Likewise.
> 	* elf32-iq2000.c (iq2000_elf_check_relocs): Likewise.
> 	* elf32-m32r.c (m32r_elf_check_relocs): Likewise.
> 	* elf32-m68hc1x.c (elf32_m68hc11_check_relocs): Likewise.
> 	* elf32-m68k.c (elf_m68k_check_relocs): Likewise.
> 	* elf32-mcore.c (mcore_elf_check_relocs): Likewise.
> 	* elf32-openrisc.c (openrisc_elf_check_relocs): Likewise.
> 	* elf32-ppc.c (ppc_elf_check_relocs): Likewise.
> 	* elf32-s390.c (elf_s390_check_relocs): Likewise.
> 	* elf32-score.c (_bfd_score_elf_check_relocs): Likewise.
> 	* elf32-sh.c (sh_elf_check_relocs): Likewise.
> 	* elf32-v850.c (v850_elf_check_relocs): Likewise.
> 	* elf32-vax.c (elf_vax_check_relocs): Likewise.
> 	* elf32-xstormy16.c (xstormy16_elf_check_relocs): Likewise.
> 	* elf32-xtensa.c (elf_xtensa_check_relocs): Likewise.
> 	* elf64-mmix.c (mmix_elf_check_relocs): Likewise.
> 	* elf64-ppc.c (ppc64_elf_check_relocs): Likewise.
> 	* elf64-s390.c (elf_s390_check_relocs): Likewise.
> 	* elf64-sh64.c (sh_elf64_check_relocs): Likewise.
> 	* elf64-x86-64.c (elf64_x86_64_check_relocs): Likewise.
> 	* elfxx-mips.c (_bfd_mips_elf_check_relocs): Likewise.
> 	* elfxx-sparc.c (_bfd_sparc_elf_check_relocs): Likewise.
> 	* elf32-hppa.c (elf32_hppa_check_relocs): Likewise. Also handle
> 	NULL pointer case for R_PARISC_GNU_VTINHERIT.

OK, except

> --- 2007-09-25/bfd/elf32-hppa.c	2007-08-22 11:01:42.000000000 +0200
> +++ 2007-09-25/bfd/elf32-hppa.c	2007-09-26 00:00:00.000000000 +0200
> @@ -1271,14 +1271,18 @@ elf32_hppa_check_relocs (bfd *abfd,
>  	  /* This relocation describes the C++ object vtable hierarchy.
>  	     Reconstruct it for later use during GC.  */
>  	case R_PARISC_GNU_VTINHERIT:
> -	  if (!bfd_elf_gc_record_vtinherit (abfd, sec, &hh->eh, rela->r_offset))
> +	  if (!bfd_elf_gc_record_vtinherit (abfd, sec,
> +					    hh != NULL ? &hh->eh : NULL,
> +					    rela->r_offset))

there is no need to change this.
&hh->eh == (struct elf_link_hash_entry *) hh

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2007-09-26 13:03 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-29  3:59 Binutils 2.18 available Daniel Jacobowitz
2007-08-29 11:36 ` Jan Beulich
2007-08-29 14:12   ` Daniel Jacobowitz
2007-08-29 16:35     ` Jan Beulich
2007-08-29 16:45       ` Daniel Jacobowitz
2007-08-30 11:17         ` Jan Beulich
2007-09-21 11:03         ` (was Re: Binutils 2.18 available) Jan Beulich
2007-09-26 11:57           ` [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 " Jan Beulich
2007-09-26 16:48             ` Alan Modra
2007-08-29 16:43 ` Binutils 2.18 available Dave Korn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).