* weak-dyn test fails on PowerPC
@ 2007-08-30 5:00 Daniel Jacobowitz
2007-08-30 13:34 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2007-08-30 5:00 UTC (permalink / raw)
To: binutils; +Cc: H.J. Lu
The test has:
SECTIONS
{
. = 0x800000;
PROVIDE (bar = .);
.data : {
*(.data)
}
}
But the PowerPC linker is placing orphans after the assignment to dot.
So .hash and others end up between bar and .data. The test fails
because the dump file checks r_offset precisely.
I think that r_offset does not matter to what we're trying to test
here and we could allow any offset as long as the relocation is
against foo. Is that right?
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: weak-dyn test fails on PowerPC
2007-08-30 5:00 weak-dyn test fails on PowerPC Daniel Jacobowitz
@ 2007-08-30 13:34 ` H.J. Lu
2007-08-30 14:12 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2007-08-30 13:34 UTC (permalink / raw)
To: binutils
On Wed, Aug 29, 2007 at 05:30:15PM -0400, Daniel Jacobowitz wrote:
> The test has:
>
> SECTIONS
> {
> . = 0x800000;
> PROVIDE (bar = .);
> .data : {
> *(.data)
> }
> }
>
> But the PowerPC linker is placing orphans after the assignment to dot.
> So .hash and others end up between bar and .data. The test fails
> because the dump file checks r_offset precisely.
>
> I think that r_offset does not matter to what we're trying to test
> here and we could allow any offset as long as the relocation is
> against foo. Is that right?
Where is the offset check? I only saw
---
#...
.* foo.*
#pass
---
in weak-dyn-1.rd.
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: weak-dyn test fails on PowerPC
2007-08-30 13:34 ` H.J. Lu
@ 2007-08-30 14:12 ` Daniel Jacobowitz
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2007-08-30 14:12 UTC (permalink / raw)
To: binutils
On Thu, Aug 30, 2007 at 06:17:27AM -0700, H.J. Lu wrote:
> Where is the offset check? I only saw
>
> ---
> #...
> .* foo.*
> #pass
> ---
>
> in weak-dyn-1.rd.
That's what I get for not checking HEAD. The offset was removed in
revision 1.2, and there was a merge conflict on our branch. Sorry.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-30 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-30 5:00 weak-dyn test fails on PowerPC Daniel Jacobowitz
2007-08-30 13:34 ` H.J. Lu
2007-08-30 14:12 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).