public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE
@ 2007-10-24 20:49 H.J. Lu
  2007-10-24 23:36 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2007-10-24 20:49 UTC (permalink / raw)
  To: binutils; +Cc: amodra

I got the following warnings:

configure.in:603: the top level
configure.in:603: warning: AC_RUN_IFELSE was called before AC_GNU_SOURCE
configure.in:86: warning: AC_COMPILE_IFELSE was called before AC_GNU_SOURCE
../../lib/autoconf/specific.m4:331: AC_GNU_SOURCE is expanded from...

with auotconf 2.59. I have been this before. We need to move
AM_PROG_LIBTOOL after AC_GNU_SOURCE. I am checking in this patch
to fix it.

H.J.
-----
gas/

2007-10-24  H.J. Lu  <hongjiu.lu@intel.com>

	* configure.in: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE.
	* configure: Regenerated.

gprof/

2007-10-24  H.J. Lu  <hongjiu.lu@intel.com>

	* configure.in: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE.
	* configure: Regenerated.

ld/

2007-10-24  H.J. Lu  <hongjiu.lu@intel.com>

	* configure.in: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE.
	* configure: Regenerated.

--- binutils/gas/configure.in.gnu	2007-10-24 09:10:26.000000000 -0700
+++ binutils/gas/configure.in	2007-10-24 09:17:32.000000000 -0700
@@ -20,6 +20,9 @@ BFD_VERSION=`sed -n -e 's/^.._INIT_AUTOM
 changequote([,])dnl
 AM_INIT_AUTOMAKE(gas, ${BFD_VERSION})
 
+AC_PROG_CC
+AC_GNU_SOURCE
+
 AM_PROG_LIBTOOL
 
 AC_ARG_ENABLE(targets,
@@ -595,9 +598,6 @@ AC_DEFINE_UNQUOTED(TARGET_CPU,		"${targe
 AC_DEFINE_UNQUOTED(TARGET_VENDOR,	"${target_vendor}", [Target vendor.])
 AC_DEFINE_UNQUOTED(TARGET_OS,		"${target_os}",    [Target OS.])
 
-AC_PROG_CC
-AC_GNU_SOURCE
-
 AC_PROG_YACC
 AM_PROG_LEX
 
--- binutils/gprof/configure.in.gnu	2007-10-24 09:10:26.000000000 -0700
+++ binutils/gprof/configure.in	2007-10-24 09:14:42.000000000 -0700
@@ -11,8 +11,6 @@ BFD_VERSION=`sed -n -e 's/^.._INIT_AUTOM
 changequote([,])dnl
 AM_INIT_AUTOMAKE(gprof, ${BFD_VERSION})
 
-AM_PROG_LIBTOOL
-
 dnl For simplicity, we use the BFD configuration file for most
 dnl things.  However, we also need our own configuration file for
 dnl the automake PACKAGE and VERSION macros.  We don't name it
@@ -23,6 +21,8 @@ AC_PROG_CC
 AC_GNU_SOURCE
 AC_PROG_INSTALL
 
+AM_PROG_LIBTOOL
+
 AC_CHECK_FUNCS(setmode)
 
 ALL_LINGUAS="fr tr sv es id da pt_BR de vi rw ga ms fi"
--- binutils/ld/configure.in.gnu	2007-10-24 09:10:26.000000000 -0700
+++ binutils/ld/configure.in	2007-10-24 09:15:30.000000000 -0700
@@ -11,8 +11,6 @@ BFD_VERSION=`sed -n -e 's/^.._INIT_AUTOM
 changequote([,])dnl
 AM_INIT_AUTOMAKE(ld, ${BFD_VERSION})
 
-AM_PROG_LIBTOOL
-
 AC_ARG_WITH(lib-path, [  --with-lib-path=dir1:dir2...  set default LIB_PATH],LIB_PATH=$withval)
 AC_ARG_ENABLE(targets,
 [  --enable-targets        alternative target configurations],
@@ -86,6 +84,8 @@ AC_PROG_CC
 AC_GNU_SOURCE
 AC_PROG_INSTALL
 
+AM_PROG_LIBTOOL
+
 ALL_LINGUAS="fr sv tr es da vi zh_CN zh_TW ga fi"
 ZW_GNU_GETTEXT_SISTER_DIR
 AM_PO_SUBDIRS

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE
  2007-10-24 20:49 PATCH: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE H.J. Lu
@ 2007-10-24 23:36 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2007-10-24 23:36 UTC (permalink / raw)
  To: H.J. Lu; +Cc: binutils

On Wed, Oct 24, 2007 at 09:41:16AM -0700, H.J. Lu wrote:
> I got the following warnings:
> 
> configure.in:603: the top level
> configure.in:603: warning: AC_RUN_IFELSE was called before AC_GNU_SOURCE
> configure.in:86: warning: AC_COMPILE_IFELSE was called before AC_GNU_SOURCE
> ../../lib/autoconf/specific.m4:331: AC_GNU_SOURCE is expanded from...
> 
> with auotconf 2.59. I have been this before. We need to move
> AM_PROG_LIBTOOL after AC_GNU_SOURCE. I am checking in this patch
> to fix it.

Thanks.  I guess I had the warnings too but I missed seeing them.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-24 23:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-24 20:49 PATCH: Move AM_PROG_LIBTOOL after AC_GNU_SOURCE H.J. Lu
2007-10-24 23:36 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).