PATCH: Use a non-ascii letter for LONG_DOUBLE_MNEM_SUFFIX

PATCH: Use a non-ascii letter for LONG_DOUBLE_MNEM_SUFFIX

[H.J. Lu]

LONG_DOUBLE_MNEM_SUFFIX never appears in instructions. I am
checking in this patch to change it.

2007-11-01  H.J. Lu  <hongjiu.lu@intel.com>

	* config/tc-i386.h (LONG_DOUBLE_MNEM_SUFFIX): Use a non-ascii
	letter.

--- gas/config/tc-i386.h.foo	2007-10-30 11:48:39.000000000 -0700
+++ gas/config/tc-i386.h	2007-11-01 11:38:07.000000000 -0700
@@ -122,8 +122,9 @@ extern const char *i386_comment_chars;
 #define SHORT_MNEM_SUFFIX 's'
 #define LONG_MNEM_SUFFIX  'l'
 #define QWORD_MNEM_SUFFIX  'q'
-/* Intel Syntax */
-#define LONG_DOUBLE_MNEM_SUFFIX 'x'
+/* Intel Syntax.  Use a non-ascii letter since since it never appears
+   in instructions.  */
+#define LONG_DOUBLE_MNEM_SUFFIX '\1'
 
 #define END_OF_INSN '\0'
 

Re: PATCH: Replace No_xSuf with No_ldSuf

[H.J. Lu]

On Thu, Nov 01, 2007 at 12:03:46PM -0700, H.J. Lu wrote:
> On Thu, Nov 01, 2007 at 11:39:26AM -0700, H.J. Lu wrote:
> > LONG_DOUBLE_MNEM_SUFFIX never appears in instructions. I am
> > checking in this patch to change it.
> > 
> > 2007-11-01  H.J. Lu  <hongjiu.lu@intel.com>
> > 
> > 	* config/tc-i386.h (LONG_DOUBLE_MNEM_SUFFIX): Use a non-ascii
> > 	letter.
> > 
> 
> I am checking in this followup patch to replace No_xSuf with No_ldSuf.
> 
> 
> H.J.
> ---
> gas/
> 
> 2007-11-01  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* config/tc-i386.c (md_assemble): Replace no_xsuf with
> 	no_ldsuf.
> 	(match_template): Likewise.
> 
> opcodes/
> 
> 2007-11-01  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* i386-gen.c (opcode_modifiers): Replace No_xSuf with
> 	No_ldSuf.
> 	* i386-opc.tbl: Likewise.
> 
> 	* i386-opc.h (No_xSuf): Renamed to ...
> 	(No_ldSuf): This.
> 	(FWait): Updated.
> 

The email didn't go through. I removed the i386-opc.tbl change.
Hopeful, it will work this time.


H.J.
---
gas/

2007-11-01  H.J. Lu  <hongjiu.lu@intel.com>

	* config/tc-i386.c (md_assemble): Replace no_xsuf with
	no_ldsuf.
	(match_template): Likewise.

opcodes/

2007-11-01  H.J. Lu  <hongjiu.lu@intel.com>

	* i386-gen.c (opcode_modifiers): Replace No_xSuf with
	No_ldSuf.
	* i386-opc.tbl: Likewise.

	* i386-opc.h (No_xSuf): Renamed to ...
	(No_ldSuf): This.
	(FWait): Updated.

--- binutils/gas/config/tc-i386.c.foo	2007-11-01 09:27:21.000000000 -0700
+++ binutils/gas/config/tc-i386.c	2007-11-01 11:55:48.000000000 -0700
@@ -2201,7 +2201,7 @@ md_assemble (line)
 		  || !i.tm.opcode_modifier.no_wsuf
 		  || !i.tm.opcode_modifier.no_lsuf
 		  || !i.tm.opcode_modifier.no_ssuf
-		  || !i.tm.opcode_modifier.no_xsuf
+		  || !i.tm.opcode_modifier.no_ldsuf
 		  || !i.tm.opcode_modifier.no_qsuf))
 	    as_bad (_("ambiguous operand size for `%s'"), i.tm.name);
 
@@ -3000,7 +3000,7 @@ match_template (void)
   else if (i.suffix == QWORD_MNEM_SUFFIX)
     suffix_check.no_qsuf = 1;
   else if (i.suffix == LONG_DOUBLE_MNEM_SUFFIX)
-    suffix_check.no_xsuf = 1;
+    suffix_check.no_ldsuf = 1;
 
   for (t = current_templates->start; t < current_templates->end; t++)
     {
@@ -3016,7 +3016,7 @@ match_template (void)
 	   || (t->opcode_modifier.no_lsuf & suffix_check.no_lsuf)
 	   || (t->opcode_modifier.no_ssuf & suffix_check.no_ssuf)
 	   || (t->opcode_modifier.no_qsuf & suffix_check.no_qsuf)
-	   || (t->opcode_modifier.no_xsuf & suffix_check.no_xsuf))
+	   || (t->opcode_modifier.no_ldsuf & suffix_check.no_ldsuf))
 	  && !(intel_syntax && t->opcode_modifier.ignoresize))
 	continue;
 
--- binutils/opcodes/i386-gen.c.foo	2007-11-01 09:27:21.000000000 -0700
+++ binutils/opcodes/i386-gen.c	2007-11-01 11:54:04.000000000 -0700
@@ -272,7 +272,7 @@ static bitfield opcode_modifiers[] =
   BITFIELD (No_lSuf),
   BITFIELD (No_sSuf),
   BITFIELD (No_qSuf),
-  BITFIELD (No_xSuf),
+  BITFIELD (No_ldSuf),
   BITFIELD (FWait),
   BITFIELD (IsString),
   BITFIELD (RegKludge),
--- binutils/opcodes/i386-opc.h.foo	2007-11-01 09:27:21.000000000 -0700
+++ binutils/opcodes/i386-opc.h	2007-11-01 11:54:16.000000000 -0700
@@ -186,10 +186,10 @@ typedef union i386_cpu_flags
 #define No_sSuf			(No_lSuf + 1)
 /* q suffix on instruction illegal */
 #define No_qSuf			(No_sSuf + 1)
-/* x suffix on instruction illegal */
-#define No_xSuf			(No_qSuf + 1)
+/* long double suffix on instruction illegal */
+#define No_ldSuf		(No_qSuf + 1)
 /* instruction needs FWAIT */
-#define FWait			(No_xSuf + 1)
+#define FWait			(No_ldSuf + 1)
 /* quick test for string instructions */
 #define IsString		(FWait + 1)
 /* fake an extra reg operand for clr, imul and special register
@@ -246,7 +246,7 @@ typedef struct i386_opcode_modifier
   unsigned int no_lsuf:1;
   unsigned int no_ssuf:1;
   unsigned int no_qsuf:1;
-  unsigned int no_xsuf:1;
+  unsigned int no_ldsuf:1;
   unsigned int fwait:1;
   unsigned int isstring:1;
   unsigned int regkludge:1;