From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11819 invoked by alias); 6 Nov 2007 21:44:09 -0000 Received: (qmail 11799 invoked by uid 22791); 6 Nov 2007 21:44:09 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Nov 2007 21:44:06 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id EBBDB98353; Tue, 6 Nov 2007 21:44:04 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 7B0809830E; Tue, 6 Nov 2007 21:44:04 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IpWDK-0004ur-Pg; Tue, 06 Nov 2007 16:44:02 -0500 Date: Tue, 06 Nov 2007 21:44:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org, binutils@sourceware.org, amodra@bigpond.net.au Subject: Re: [rfc, v2] Fix ELF synthetic symbol size bug (affects PPC64) Message-ID: <20071106214402.GA18867@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org, binutils@sourceware.org, amodra@bigpond.net.au References: <200711052014.lA5KEiTm019854@d12av02.megacenter.de.ibm.com> <200711062133.lA6LX4nq031372@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200711062133.lA6LX4nq031372@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00045.txt.bz2 On Tue, Nov 06, 2007 at 10:33:04PM +0100, Ulrich Weigand wrote: > Alan suggested a way to pass that information: have the udata.p > member of the synthetic symbol point back to the full ELF symbol > structure of the original symbol used to derive the synthetic > symbol from. The patch below implements this. > > Tested (GDB) on powerpc64-linux, fixes another 12 FAILs on top > of the ones already fixed by the original patch. > > Is the bfd part OK? The elf.c part of this does not make sense to me. Why should we have the same size as that symbol? The @plt entry is only a couple of instructions. To figure out its size you need to ask the backend plt_sym_val routine. -- Daniel Jacobowitz CodeSourcery