public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Nathan Sidwell <nathan@codesourcery.com>
Cc: binutils <binutils@sources.redhat.com>
Subject: Re: vxworks dynamic tls relocs
Date: Tue, 13 Nov 2007 23:39:00 -0000	[thread overview]
Message-ID: <20071113233857.GB14068@bubble.grove.modra.org> (raw)
In-Reply-To: <47399CE5.4070902@codesourcery.com>

On Tue, Nov 13, 2007 at 12:47:33PM +0000, Nathan Sidwell wrote:
> Nullifying the dynamic reloc seemed the simplest approach to take, rather 
> than change the size of the dynamic reloc section.

It is only marginally more difficult to do this without generating
those NONE relocs.  For example, in elf32-ppc.c allocate_dynrelocs
around line 4802, add

    if (htab->is_vxworks && info->shared)
      {
	struct ppc_elf_dyn_relocs **pp;

	for (pp = &eh->dyn_relocs; (p = *pp) != NULL; )
	  {
	    if (strcmp (p->sec->output_section->name, ".tls_vars") == 0)
	      *pp = p->next;
	    else
	      pp = &p->next;
	  }
      }

then in ppc_elf_relocate_section change the "dodyn" condition to

	  if ((input_section->flags & SEC_ALLOC) == 0
	      || is_vxworks_tls)
	    break;

Please take a look at doing it this way.

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2007-11-13 23:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13 12:47 Nathan Sidwell
2007-11-13 23:39 ` Alan Modra [this message]
2007-12-19 16:18   ` Nathan Sidwell
2007-12-22  9:17     ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071113233857.GB14068@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=nathan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).