public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] MIPS BFD: Avoid unwanted fallthroughs in elfxx-mips.c
@ 2007-11-14 20:07 Thiemo Seufer
  0 siblings, 0 replies; only message in thread
From: Thiemo Seufer @ 2007-11-14 20:07 UTC (permalink / raw)
  To: binutils

Hello All,

I committed the appended patch, it fixes a logic bug which caused
in some cases two lines of output, only one of them valid.


Thiemo


2007-11-14  Thiemo Seufer  <ths@mips.com>

	* elfxx-mips.c (mips_elf_merge_obj_attributes): Prevent
	unwanted fallthroughs in case statement.

Index: head/bfd/elfxx-mips.c
===================================================================
--- head.orig/bfd/elfxx-mips.c	2007-11-14 19:01:31.000000000 +0000
+++ head/bfd/elfxx-mips.c	2007-11-14 19:15:45.000000000 +0000
@@ -11073,6 +11073,7 @@
 		_bfd_error_handler
 		  (_("Warning: %B uses -msingle-float, %B uses -mdouble-float"),
 		   obfd, ibfd);
+		break;
 
 	      case 3:
 		_bfd_error_handler
@@ -11092,6 +11093,7 @@
 		_bfd_error_handler
 		  (_("Warning: %B uses -msingle-float, %B uses -mdouble-float"),
 		   ibfd, obfd);
+		break;
 
 	      case 3:
 		_bfd_error_handler

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-11-14 20:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-14 20:07 [PATCH] MIPS BFD: Avoid unwanted fallthroughs in elfxx-mips.c Thiemo Seufer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).