From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Subject: Re: PATCH: PR ld/6931: COMDAT group is broken
Date: Fri, 03 Oct 2008 13:03:00 -0000 [thread overview]
Message-ID: <20081003130309.GJ7258@bubble.grove.modra.org> (raw)
In-Reply-To: <20081003094616.GH7258@bubble.grove.modra.org>
On Fri, Oct 03, 2008 at 07:16:16PM +0930, Alan Modra wrote:
> Finally, I tweaked the various emulation's place_orphan code to not
> use an existing output section statement if it did not already have a
> bfd section. This is because a new bfd section will be created after
> all other existing sections, which is probably the wrong ordering.
> lang_place_orphan knows how to rearrange sections.
One testcase expected the wrong order.
* ld-powerpc/vxworks1-lib.rd: Update.
Index: ld/testsuite/ld-powerpc/vxworks1-lib.rd
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-powerpc/vxworks1-lib.rd,v
retrieving revision 1.4
diff -u -p -r1.4 vxworks1-lib.rd
--- ld/testsuite/ld-powerpc/vxworks1-lib.rd 15 May 2007 12:22:34 -0000 1.4
+++ ld/testsuite/ld-powerpc/vxworks1-lib.rd 3 Oct 2008 12:59:44 -0000
@@ -1,9 +1,4 @@
-Relocation section '\.rela\.plt' at offset .* contains 2 entries:
- Offset Info Type Sym\.Value Sym\. Name \+ Addend
-0009040c .*15 R_PPC_JMP_SLOT 00000000 sexternal \+ 0
-00090410 .*15 R_PPC_JMP_SLOT 00080c48 sglobal \+ 0
-
Relocation section '\.rela\.dyn' at offset .* contains 5 entries:
Offset Info Type Sym\.Value Sym\. Name \+ Addend
00090800 00000016 R_PPC_RELATIVE * 00080c44
@@ -11,3 +6,8 @@ Relocation section '\.rela\.dyn' at offs
00080c12 .*04 R_PPC_ADDR16_LO 00000000 __GOTT_BASE__ \+ 0
00080c16 .*03 R_PPC_ADDR16 00000000 __GOTT_INDEX__ \+ 0
00090414 .*14 R_PPC_GLOB_DAT 00090c00 x \+ 0
+
+Relocation section '\.rela\.plt' at offset .* contains 2 entries:
+ Offset Info Type Sym\.Value Sym\. Name \+ Addend
+0009040c .*15 R_PPC_JMP_SLOT 00000000 sexternal \+ 0
+00090410 .*15 R_PPC_JMP_SLOT 00080c48 sglobal \+ 0
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2008-10-03 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 21:43 H.J. Lu
2008-10-03 0:30 ` H.J. Lu
2008-10-03 9:47 ` Alan Modra
2008-10-03 13:03 ` Alan Modra [this message]
2008-10-03 15:11 ` H.J. Lu
2008-10-03 19:41 ` H.J. Lu
2008-10-04 6:14 ` Alan Modra
2008-10-04 14:56 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003130309.GJ7258@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).