From: Thiemo Seufer <ths@networkno.de>
To: Tristan Gingold <gingold@adacore.com>
Cc: binutils@sources.redhat.com
Subject: Re: mips-elf regressions
Date: Wed, 08 Oct 2008 10:01:00 -0000 [thread overview]
Message-ID: <20081008100026.GA18570@networkno.de> (raw)
In-Reply-To: <5886B2C6-4718-40B1-B57F-3FF3E5115756@adacore.com>
Tristan Gingold wrote:
>
> On Oct 8, 2008, at 10:29 AM, Tristan Gingold wrote:
>> (Locals must be before Weaks and Weaks must be before Globals
>> according to gabi).
>> As a consequence the output don't match the expected result.
>
> Well according to elf32-mips.c, this is expected:
>
> /* Determine whether a symbol is global for the purposes of splitting
> the symbol table into global symbols and local symbols. At least
> on Irix 5, this split must be between section symbols and all other
> symbols. On most ELF targets the split is between static symbols
> and externally visible symbols. */
>
> static bfd_boolean
> mips_elf_sym_is_global (bfd *abfd ATTRIBUTE_UNUSED, asymbol *sym)
> {
> if (SGI_COMPAT (abfd))
> return (sym->flags & BSF_SECTION_SYM) == 0;
> else
> return ((sym->flags & (BSF_GLOBAL | BSF_WEAK)) != 0
> || bfd_is_und_section (bfd_get_section (sym))
> || bfd_is_com_section (bfd_get_section (sym)));
> }
>
> As SGI_COMPAT is true, this looks to be expected.
>
> Can someone confirm this ?
This is correct. mips-elf uses the SGI-ish object layout with
nonstandard (or pre-standard?) symbol sorting.
> If so, shouldn't we update the status of the failing tests (either
> disabling them on mips-elf or marking
> them as xfail) ?
I think the test needs to check for different expected output for
mips-elf and mips-sgi-irix*
Thiemo
next prev parent reply other threads:[~2008-10-08 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 8:28 Tristan Gingold
2008-10-08 8:49 ` Tristan Gingold
2008-10-08 10:01 ` Thiemo Seufer [this message]
2008-10-08 15:01 ` Ian Lance Taylor
2008-10-08 10:14 ` Alan Modra
2008-10-08 10:19 ` Tristan Gingold
2008-10-08 11:14 ` Alan Modra
2008-10-08 12:38 ` Maciej W. Rozycki
2008-10-08 20:08 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008100026.GA18570@networkno.de \
--to=ths@networkno.de \
--cc=binutils@sources.redhat.com \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).