From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [Patch] Mach-O: add write capability
Date: Fri, 05 Jun 2009 21:21:00 -0000 [thread overview]
Message-ID: <20090605212111.GA13833@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <B051D61B-9878-4A83-93F1-2078376AFD37@adacore.com>
On Tue, 02 Jun 2009 16:40:33 +0200, Tristan Gingold wrote:
> I did some manual checks to test this new feature.
With --enable-targets=all standard x86_64 GDB build broke now:
../bfd/libbfd.a(targets.o):(.rodata+0x618): undefined reference to `mach_o_i386_vec'
../bfd/libbfd.a(targets.o):(.rodata+0x29c8): undefined reference to `mach_o_i386_vec'
collect2: ld returned 1 exit status
(specifically tried ./configure --enable-64-bit-bfd --enable-targets=all
--enable-static --disable-shared --enable-debug)
OK to check-in?
Regards,
Jan
2009-06-05 Jan Kratochvil <jan.kratochvil@redhat.com>
* Makefile.am: Run "make dep-am".
(BFD32_BACKENDS): Add mach-o-i386.lo.
(BFD32_BACKENDS_CFILES): Add mach-o-i386.c.
* Makefile.in: Regenerate.
--- bfd/Makefile.am 4 Jun 2009 06:51:11 -0000 1.230
+++ bfd/Makefile.am 5 Jun 2009 21:16:10 -0000
@@ -333,6 +333,7 @@ BFD32_BACKENDS = \
m88kmach3.lo \
m88kopenbsd.lo \
mach-o.lo \
+ mach-o-i386.lo \
mipsbsd.lo \
newsos3.lo \
nlm.lo \
@@ -514,6 +515,7 @@ BFD32_BACKENDS_CFILES = \
m88kmach3.c \
m88kopenbsd.c \
mach-o.c \
+ mach-o-i386.c \
mipsbsd.c \
newsos3.c \
nlm.c \
@@ -3090,6 +3092,13 @@ mach-o.lo: \
$(INCDIR)/libiberty.h \
mach-o-target.c \
mach-o.h
+mach-o-i386.lo: \
+ mach-o-i386.c \
+ $(INCDIR)/filenames.h \
+ $(INCDIR)/hashtab.h \
+ $(INCDIR)/libiberty.h \
+ mach-o-target.c \
+ mach-o.h
mipsbsd.lo: \
mipsbsd.c \
$(INCDIR)/aout/aout64.h \
--- bfd/Makefile.in 4 Jun 2009 06:51:11 -0000 1.254
+++ bfd/Makefile.in 5 Jun 2009 21:16:10 -0000
@@ -604,6 +604,7 @@ BFD32_BACKENDS = \
m88kmach3.lo \
m88kopenbsd.lo \
mach-o.lo \
+ mach-o-i386.lo \
mipsbsd.lo \
newsos3.lo \
nlm.lo \
@@ -785,6 +786,7 @@ BFD32_BACKENDS_CFILES = \
m88kmach3.c \
m88kopenbsd.c \
mach-o.c \
+ mach-o-i386.c \
mipsbsd.c \
newsos3.c \
nlm.c \
@@ -3691,6 +3693,13 @@ mach-o.lo: \
$(INCDIR)/libiberty.h \
mach-o-target.c \
mach-o.h
+mach-o-i386.lo: \
+ mach-o-i386.c \
+ $(INCDIR)/filenames.h \
+ $(INCDIR)/hashtab.h \
+ $(INCDIR)/libiberty.h \
+ mach-o-target.c \
+ mach-o.h
mipsbsd.lo: \
mipsbsd.c \
$(INCDIR)/aout/aout64.h \
next prev parent reply other threads:[~2009-06-05 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 14:41 Tristan Gingold
2009-06-05 21:21 ` Jan Kratochvil [this message]
2009-06-06 1:16 ` Alan Modra
2009-06-06 7:50 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605212111.GA13833@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=binutils@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).