From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17267 invoked by alias); 5 Jun 2009 21:21:46 -0000 Received: (qmail 17241 invoked by uid 22791); 5 Jun 2009 21:21:45 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_32,J_CHICKENPOX_72,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 21:21:40 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n55LLGVl010893; Fri, 5 Jun 2009 17:21:16 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n55LLFjf026965; Fri, 5 Jun 2009 17:21:15 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n55LLDld020760; Fri, 5 Jun 2009 17:21:14 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n55LLDkN025549; Fri, 5 Jun 2009 23:21:13 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n55LLBcv025542; Fri, 5 Jun 2009 23:21:11 +0200 Date: Fri, 05 Jun 2009 21:21:00 -0000 From: Jan Kratochvil To: Tristan Gingold Cc: Binutils Subject: Re: [Patch] Mach-O: add write capability Message-ID: <20090605212111.GA13833@host0.dyn.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00119.txt.bz2 On Tue, 02 Jun 2009 16:40:33 +0200, Tristan Gingold wrote: > I did some manual checks to test this new feature. With --enable-targets=all standard x86_64 GDB build broke now: ../bfd/libbfd.a(targets.o):(.rodata+0x618): undefined reference to `mach_o_i386_vec' ../bfd/libbfd.a(targets.o):(.rodata+0x29c8): undefined reference to `mach_o_i386_vec' collect2: ld returned 1 exit status (specifically tried ./configure --enable-64-bit-bfd --enable-targets=all --enable-static --disable-shared --enable-debug) OK to check-in? Regards, Jan 2009-06-05 Jan Kratochvil * Makefile.am: Run "make dep-am". (BFD32_BACKENDS): Add mach-o-i386.lo. (BFD32_BACKENDS_CFILES): Add mach-o-i386.c. * Makefile.in: Regenerate. --- bfd/Makefile.am 4 Jun 2009 06:51:11 -0000 1.230 +++ bfd/Makefile.am 5 Jun 2009 21:16:10 -0000 @@ -333,6 +333,7 @@ BFD32_BACKENDS = \ m88kmach3.lo \ m88kopenbsd.lo \ mach-o.lo \ + mach-o-i386.lo \ mipsbsd.lo \ newsos3.lo \ nlm.lo \ @@ -514,6 +515,7 @@ BFD32_BACKENDS_CFILES = \ m88kmach3.c \ m88kopenbsd.c \ mach-o.c \ + mach-o-i386.c \ mipsbsd.c \ newsos3.c \ nlm.c \ @@ -3090,6 +3092,13 @@ mach-o.lo: \ $(INCDIR)/libiberty.h \ mach-o-target.c \ mach-o.h +mach-o-i386.lo: \ + mach-o-i386.c \ + $(INCDIR)/filenames.h \ + $(INCDIR)/hashtab.h \ + $(INCDIR)/libiberty.h \ + mach-o-target.c \ + mach-o.h mipsbsd.lo: \ mipsbsd.c \ $(INCDIR)/aout/aout64.h \ --- bfd/Makefile.in 4 Jun 2009 06:51:11 -0000 1.254 +++ bfd/Makefile.in 5 Jun 2009 21:16:10 -0000 @@ -604,6 +604,7 @@ BFD32_BACKENDS = \ m88kmach3.lo \ m88kopenbsd.lo \ mach-o.lo \ + mach-o-i386.lo \ mipsbsd.lo \ newsos3.lo \ nlm.lo \ @@ -785,6 +786,7 @@ BFD32_BACKENDS_CFILES = \ m88kmach3.c \ m88kopenbsd.c \ mach-o.c \ + mach-o-i386.c \ mipsbsd.c \ newsos3.c \ nlm.c \ @@ -3691,6 +3693,13 @@ mach-o.lo: \ $(INCDIR)/libiberty.h \ mach-o-target.c \ mach-o.h +mach-o-i386.lo: \ + mach-o-i386.c \ + $(INCDIR)/filenames.h \ + $(INCDIR)/hashtab.h \ + $(INCDIR)/libiberty.h \ + mach-o-target.c \ + mach-o.h mipsbsd.lo: \ mipsbsd.c \ $(INCDIR)/aout/aout64.h \