From: Daniel Jacobowitz <drow@false.org>
To: Christophe LYON <christophe.lyon@st.com>
Cc: Nick Clifton <nickc@redhat.com>, Phil Blundell <pb@reciva.com>,
binutils@sourceware.org
Subject: Re: linker crash in arm stub generation
Date: Fri, 12 Jun 2009 14:06:00 -0000 [thread overview]
Message-ID: <20090612140642.GA31950@caradoc.them.org> (raw)
In-Reply-To: <4A3255D9.9030906@st.com>
On Fri, Jun 12, 2009 at 03:19:21PM +0200, Christophe LYON wrote:
> I think your patch is not adequate: it will prevent the stub code from
> being generated, but the user code will still jump to the stub. So the
> link won't fail, but the result will be wrong.
>
> Instead, I propose this patch, which prevents mode-switching stub
> generation when the call goes through a PLT entry.
>
> I think there should already be a test for this in the testsuite, I have
> probably forgotten this configuration.
This looks good to me - and I agree that a test would be helpful!
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-06-12 14:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 17:09 Phil Blundell
2009-06-12 12:36 ` Nick Clifton
2009-06-12 13:19 ` Christophe LYON
2009-06-12 13:49 ` Nick Clifton
2009-06-12 14:06 ` Daniel Jacobowitz [this message]
2009-06-12 14:13 ` Christophe LYON
2009-06-15 14:22 ` Christophe LYON
2009-06-15 17:59 ` Daniel Jacobowitz
2009-06-17 15:44 ` Christophe LYON
2009-06-17 16:09 ` Phil Blundell
2009-06-17 18:10 ` Daniel Jacobowitz
2009-06-18 14:25 ` Christophe LYON
2009-06-18 14:36 ` Christophe LYON
2009-06-22 9:24 ` Nick Clifton
2009-06-22 11:33 ` Christophe LYON
2009-08-26 1:21 ` Fix Thumb-2 shared libraries Daniel Jacobowitz
2009-08-26 3:11 ` Daniel Jacobowitz
2009-09-09 18:36 ` Daniel Jacobowitz
2009-09-14 12:30 ` Daniel Jacobowitz
2009-08-26 10:39 ` Christophe LYON
2009-08-26 15:00 ` Daniel Jacobowitz
2009-08-26 17:24 ` Christophe LYON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612140642.GA31950@caradoc.them.org \
--to=drow@false.org \
--cc=binutils@sourceware.org \
--cc=christophe.lyon@st.com \
--cc=nickc@redhat.com \
--cc=pb@reciva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).