From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24224 invoked by alias); 12 Jun 2009 14:06:54 -0000 Received: (qmail 24205 invoked by uid 22791); 12 Jun 2009 14:06:53 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Jun 2009 14:06:46 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 1347C108CD; Fri, 12 Jun 2009 14:06:44 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id D0D65108CC; Fri, 12 Jun 2009 14:06:43 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MF7P0-0008RP-E7; Fri, 12 Jun 2009 10:06:42 -0400 Date: Fri, 12 Jun 2009 14:06:00 -0000 From: Daniel Jacobowitz To: Christophe LYON Cc: Nick Clifton , Phil Blundell , binutils@sourceware.org Subject: Re: linker crash in arm stub generation Message-ID: <20090612140642.GA31950@caradoc.them.org> Mail-Followup-To: Christophe LYON , Nick Clifton , Phil Blundell , binutils@sourceware.org References: <1244740179.21585.119.camel@mill.internal.reciva.com> <4A324BAC.7090702@redhat.com> <4A3255D9.9030906@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A3255D9.9030906@st.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00194.txt.bz2 On Fri, Jun 12, 2009 at 03:19:21PM +0200, Christophe LYON wrote: > I think your patch is not adequate: it will prevent the stub code from > being generated, but the user code will still jump to the stub. So the > link won't fail, but the result will be wrong. > > Instead, I propose this patch, which prevents mode-switching stub > generation when the call goes through a PLT entry. > > I think there should already be a test for this in the testsuite, I have > probably forgotten this configuration. This looks good to me - and I agree that a test would be helpful! -- Daniel Jacobowitz CodeSourcery