From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28121 invoked by alias); 14 Aug 2009 07:43:09 -0000 Received: (qmail 28055 invoked by uid 22791); 14 Aug 2009 07:43:08 -0000 X-SWARE-Spam-Status: No, hits=2.4 required=5.0 tests=BAYES_00,BOTNET,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.gmx.com (HELO mail.gmx.com) (213.165.64.42) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 14 Aug 2009 07:42:59 +0000 Received: (qmail invoked by alias); 14 Aug 2009 07:42:56 -0000 Received: from host86-158-51-100.range86-158.btcentralplus.com (EHLO kenny) [86.158.51.100] by mail.gmx.com (mp-eu004) with SMTP; 14 Aug 2009 09:42:56 +0200 From: Nick Hudson To: binutils@sourceware.org Subject: Re: [hppa] Fix disassembly of bb condition codes Date: Fri, 14 Aug 2009 07:43:00 -0000 User-Agent: KMail/1.9.10 Cc: "John David Anglin" , randolph@tausq.org References: <200603042215.k24MF5jq023181@hiauly1.hia.nrc.ca> In-Reply-To: <200603042215.k24MF5jq023181@hiauly1.hia.nrc.ca> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908140842.42891.nick.hudson@gmx.co.uk> Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00219.txt.bz2 On Saturday 04 March 2006 22:15:05 John David Anglin wrote: > > > Currently binutils doesn't properly differentiate between 32-bit and > > > 64-bit condition codes for the hppa bb insn, always disassembling the > > > condition code as a 64-bit condition if it is in pa20 mode. This patch > > > fixes the problem. > > > > I don't believe the change is correct. 'B' is for 64-bit conditions. > > This affects the printed bit position. So, printing a 32-bit code with > > a 64-bit position would be wrong. > > I've committed the following change. Tested on hppa-unknown-linux-gnu > and by visually inspecting the disassembly of some bb instructions. > Let me know if you see any problems. This breaks, e.g. sign: .equ 8 bb sign, 0, foo as FLAG_STRICT is now set on all entries. Not sure what the fix is Nick