From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5566 invoked by alias); 28 Aug 2009 00:40:04 -0000 Received: (qmail 5557 invoked by uid 22791); 28 Aug 2009 00:40:03 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_22 X-Spam-Check-By: sourceware.org Received: from nschwmtas04p.mx.bigpond.com (HELO nschwmtas04p.mx.bigpond.com) (61.9.189.146) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 00:39:57 +0000 Received: from nschwotgx02p.mx.bigpond.com ([121.209.33.16]) by nschwmtas04p.mx.bigpond.com with ESMTP id <20090828003953.HTOO2030.nschwmtas04p.mx.bigpond.com@nschwotgx02p.mx.bigpond.com>; Fri, 28 Aug 2009 00:39:53 +0000 Received: from bubble.grove.modra.org ([121.209.33.16]) by nschwotgx02p.mx.bigpond.com with ESMTP id <20090828003952.YQTM4842.nschwotgx02p.mx.bigpond.com@bubble.grove.modra.org>; Fri, 28 Aug 2009 00:39:52 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 8E1D0170C880; Fri, 28 Aug 2009 10:09:52 +0930 (CST) Date: Fri, 28 Aug 2009 03:32:00 -0000 From: Alan Modra To: Peter Bergner , "binutils@sourceware.org" Subject: Re: Handle extrdi and large register rotate values Message-ID: <20090828003952.GB19523@bubble.grove.modra.org> Mail-Followup-To: Peter Bergner , "binutils@sourceware.org" References: <1251412176.5257.51.camel@otta> <20090828001501.GA19523@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090828001501.GA19523@bubble.grove.modra.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150202.4A972759.005F,ss=1,fgs=0 X-SIH-MSG-ID: rxg7ENT4TAD0zmRy0WWwOwRzyFrsq3B48Z4QWs1mqRMGT0XduMfONYj6Y9IElp7k3C5MNhCGN2slYLzmXY/YiA== X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00516.txt.bz2 On Fri, Aug 28, 2009 at 09:45:01AM +0930, Alan Modra wrote: > On Thu, Aug 27, 2009 at 05:29:36PM -0500, Peter Bergner wrote: > > -{"extrdi", 4, PPC64, "rldicl %0,%1,(%2)+(%3),64-(%2)"}, > > -{"extrdi.", 4, PPC64, "rldicl. %0,%1,(%2)+(%3),64-(%2)"}, > > +{"extrdi", 4, PPC64, "rldicl %0,%1,((%2)+(%3))&0x3f,64-(%2)"}, > > +{"extrdi.", 4, PPC64, "rldicl. %0,%1,((%2)+(%3))&0x3f,64-(%2)"}, > > > > but that would mean updating quite a few other ops similarly. Is the > > following patch acceptable to catch them all in one shot or do you > > prefer a change like the above? > > I prefer this. For your other patch, you'd need to argue that the > current warning on plain rldicl shift counts isn't useful. Hmm, extrdi ra,rs,n,b has number of bits n = [1,64] and bit position b = [0,63]. Also, the bit field ends at bit 63, so n+b = [1,64] So I think you should have {"extrdi", 4, PPC64, "rldicl %0,%1,((%2)+(%3))&((%2)+(%3)<>64),64-(%2)"}, -- Alan Modra Australia Development Lab, IBM