From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7379 invoked by alias); 28 Aug 2009 03:14:21 -0000 Received: (qmail 7370 invoked by uid 22791); 28 Aug 2009 03:14:20 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from nschwmtas01p.mx.bigpond.com (HELO nschwmtas01p.mx.bigpond.com) (61.9.189.137) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 03:14:15 +0000 Received: from nschwotgx03p.mx.bigpond.com ([121.209.33.16]) by nschwmtas01p.mx.bigpond.com with ESMTP id <20090828031411.XTAA26885.nschwmtas01p.mx.bigpond.com@nschwotgx03p.mx.bigpond.com>; Fri, 28 Aug 2009 03:14:11 +0000 Received: from bubble.grove.modra.org ([121.209.33.16]) by nschwotgx03p.mx.bigpond.com with ESMTP id <20090828031411.ZQDH1120.nschwotgx03p.mx.bigpond.com@bubble.grove.modra.org>; Fri, 28 Aug 2009 03:14:11 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id F14BD170C880; Fri, 28 Aug 2009 12:44:10 +0930 (CST) Date: Fri, 28 Aug 2009 03:55:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sources.redhat.com Subject: Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts Message-ID: <20090828031410.GC19523@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sources.redhat.com References: <20090828000233.GA23692@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090828000233.GA23692@lucon.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150204.4A974B83.00BD,ss=1,fgs=0 X-SIH-MSG-ID: rB01ENb5TAD0zmRy0WWwOwRzyFrsq3B48Z4QWs1mqRMGT0XduMfONYj6Y9IElp7k3C5MNRCEOmshYrzmXY/YiA== X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00517.txt.bz2 On Thu, Aug 27, 2009 at 05:02:33PM -0700, H.J. Lu wrote: > PR ld/10569 > * ldlang.c (lang_add_output_format): Call > bfd_emul_set_maxpagesize/bfd_emul_set_commonpagesize if > maximum/common page sizes are specified and output target > isn't the same as default target. I think this is the wrong place to call bfd_emul_set_maxpagesize (and the current call in elf32.em is wrong too). You probably should be calling bfd_emul_set_maxpagesize in open_output. Also, bfd_emul_get_maxpagesize in fold_name shouldn't be using default_target. Ditto for commonpagesize. -- Alan Modra Australia Development Lab, IBM