From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10208 invoked by alias); 28 Aug 2009 05:50:31 -0000 Received: (qmail 10188 invoked by uid 22791); 28 Aug 2009 05:50:28 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from nschwmtas05p.mx.bigpond.com (HELO nschwmtas05p.mx.bigpond.com) (61.9.189.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 05:50:21 +0000 Received: from nschwotgx03p.mx.bigpond.com ([121.209.33.16]) by nschwmtas05p.mx.bigpond.com with ESMTP id <20090828055017.DKLG1928.nschwmtas05p.mx.bigpond.com@nschwotgx03p.mx.bigpond.com>; Fri, 28 Aug 2009 05:50:17 +0000 Received: from bubble.grove.modra.org ([121.209.33.16]) by nschwotgx03p.mx.bigpond.com with ESMTP id <20090828055016.HZDX1120.nschwotgx03p.mx.bigpond.com@bubble.grove.modra.org>; Fri, 28 Aug 2009 05:50:16 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 98E35170C880; Fri, 28 Aug 2009 15:20:16 +0930 (CST) Date: Fri, 28 Aug 2009 08:09:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sources.redhat.com Subject: Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts Message-ID: <20090828055016.GE19523@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sources.redhat.com References: <20090828000233.GA23692@lucon.org> <20090828031410.GC19523@bubble.grove.modra.org> <6dc9ffc80908272032p5b5a54a6h75caad74a27ffeda@mail.gmail.com> <6dc9ffc80908272055l3daa1368l1f84cfafcc07c2de@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6dc9ffc80908272055l3daa1368l1f84cfafcc07c2de@mail.gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150203.4A977019.0074,ss=1,fgs=0 X-SIH-MSG-ID: rx8yFNf6TAD0zmRy0WWwOwRzyFrsq3B48Z4QWs1mqRMGT0XduMfONYj6Y9IElp7k3C5MMxCAPmshZLzmXY/YiA== X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00520.txt.bz2 On Thu, Aug 27, 2009 at 08:55:46PM -0700, H.J. Lu wrote: > On Thu, Aug 27, 2009 at 8:32 PM, H.J. Lu wrote: > > On Thu, Aug 27, 2009 at 8:14 PM, Alan Modra wrote: > >> I think this is the wrong place to call bfd_emul_set_maxpagesize > >> (and the current call in elf32.em is wrong too).  You probably should > >> be calling bfd_emul_set_maxpagesize in open_output.  Also, > > > > Will open_output be called before any linker scripts are processed? Depends on what you mean by processed. Yes, they are parsed and converted to internal format before open_output, but why does it matter? Nothing much depends on maxpagesize until lang_size_sections. Perhaps even a nicer patch would be to put your bfd_emul_set_maxpagesize calls in a LD_EMUL_SET_OUTPUT_ARCH hook, which is called just after open_output. > >> bfd_emul_get_maxpagesize in fold_name shouldn't be using > >> default_target.  Ditto for commonpagesize. > >> > > > > That is true. I will fix it. > > There is no easy fix. Should we just set max/common page sizes for > all enabled ELF targets? Why can't you use output_target? -- Alan Modra Australia Development Lab, IBM