From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19540 invoked by alias); 31 Aug 2009 02:50:36 -0000 Received: (qmail 19532 invoked by uid 22791); 31 Aug 2009 02:50:36 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from nschwmtas06p.mx.bigpond.com (HELO nschwmtas06p.mx.bigpond.com) (61.9.189.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Aug 2009 02:50:27 +0000 Received: from nschwotgx02p.mx.bigpond.com ([121.209.33.16]) by nschwmtas06p.mx.bigpond.com with ESMTP id <20090831025024.HUXZ1920.nschwmtas06p.mx.bigpond.com@nschwotgx02p.mx.bigpond.com>; Mon, 31 Aug 2009 02:50:24 +0000 Received: from bubble.grove.modra.org ([121.209.33.16]) by nschwotgx02p.mx.bigpond.com with ESMTP id <20090831025024.QNPO4842.nschwotgx02p.mx.bigpond.com@bubble.grove.modra.org>; Mon, 31 Aug 2009 02:50:24 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id CB0C3170C880; Mon, 31 Aug 2009 12:20:23 +0930 (CST) Date: Mon, 31 Aug 2009 09:09:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils Subject: Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts Message-ID: <20090831025023.GR19523@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils References: <6dc9ffc80908272032p5b5a54a6h75caad74a27ffeda@mail.gmail.com> <6dc9ffc80908272055l3daa1368l1f84cfafcc07c2de@mail.gmail.com> <20090828055016.GE19523@bubble.grove.modra.org> <6dc9ffc80908280640q35b52922gda316d43127b7ab7@mail.gmail.com> <20090828143141.GK19523@bubble.grove.modra.org> <6dc9ffc80908280737q3b02c3e1ybfec435dd9307512@mail.gmail.com> <20090830054221.GM19523@bubble.grove.modra.org> <6dc9ffc80908301142h6b7364cew9dca8f5198b366fa@mail.gmail.com> <20090831014723.GQ19523@bubble.grove.modra.org> <6dc9ffc80908301902y59e745f8jff2ec9f88ea07ac1@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dc9ffc80908301902y59e745f8jff2ec9f88ea07ac1@mail.gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150201.4A9B3A70.00B3,ss=1,fgs=0 X-SIH-MSG-ID: rRE2Fdz+TAD0zmRy0WWwOwRzyFrsq3B48Z4QWs1mqRMGT0XduMfOPpX9Y9IElp7l1S5MNBCAPmsiZ7zmXY/YiA== X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00566.txt.bz2 On Sun, Aug 30, 2009 at 07:02:47PM -0700, H.J. Lu wrote: > On Sun, Aug 30, 2009 at 6:47 PM, Alan Modra wrote: > > On Sun, Aug 30, 2009 at 11:42:20AM -0700, H.J. Lu wrote: > >> What should happen case where > >> > >> 1. No -z page size command line option is given. > >> 2. Output target is ELF and whose page size is different from default target. > >> > >> Your checkin changes the output page size to the page size of the default > >> target. > > > > Yes, I treat "--oformat other_elf" just the same as "--oformat srec". > > I don't really have a strong opinion as to what should be done in > > this case. > > > > It can also happen with > > OUTPUT_FORMAT("elf32-i386") > OUTPUT_ARCH(i386) > > in linker script and all input files are elf32-i386. I won't expect > the page size > won't be 4KB. This is a regression. You're kidding me. A regression? A change in behaviour for a contrived test case, you mean. We had this case wrong before my patch anyway, in an even worse way. "CONSTANT (MAXPAGESIZE)" in a linker script would use the default emulation maxpagesize, while the backend bfd linker would use the output target maxpagesize. -- Alan Modra Australia Development Lab, IBM