From: Alan Modra <amodra@bigpond.net.au>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [patch 0/3] Fix some FAILS for: unordered .debug_info references to .debug_ranges
Date: Wed, 09 Sep 2009 09:31:00 -0000 [thread overview]
Message-ID: <20090909093139.GA28290@bubble.grove.modra.org> (raw)
In-Reply-To: <20090907033218.GA20107@host0.dyn.jankratochvil.net>
On Mon, Sep 07, 2009 at 05:32:18AM +0200, Jan Kratochvil wrote:
> These targets:
> i686-pc-cygwin mingw32-pe x86_64-mingw32
>
> fail on
> ./configure --target=$TARGET --enable-targets=all; make
>
> with
> config/tc-i386.c: In function 'i386_target_format':
> config/tc-i386.c:8099: error: duplicate case value
> config/tc-i386.c:8088: error: previously used here
>
> This failure was already present before my patch
> [patch 1/4] Fix compilation for i386-unknown-go32 with secondary as elf
> http://sourceware.org/ml/binutils/2009-08/msg00152.html
>
> and I will post a separate patch for it.
I haven't yet seen a patch for this problem, so I'm going ahead and
committing this one.
* config/tc-i386.c (i386_target_format): Avoid duplicate case label.
Index: gas/config/tc-i386.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-i386.c,v
retrieving revision 1.391
diff -u -p -r1.391 tc-i386.c
--- gas/config/tc-i386.c 29 Aug 2009 22:10:59 -0000 1.391
+++ gas/config/tc-i386.c 9 Sep 2009 07:34:06 -0000
@@ -8084,20 +8084,21 @@ i386_target_format (void)
as_fatal (_("Unknown architecture"));
switch (OUTPUT_FLAVOR)
{
-#if defined (TE_PE) || defined (TE_PEP)
- case bfd_target_coff_flavour:
- return flag_code == CODE_64BIT ? "pe-x86-64" : "pe-i386";
-#endif
-#ifdef OBJ_MAYBE_AOUT
+#if defined (OBJ_MAYBE_AOUT) || defined (OBJ_AOUT)
case bfd_target_aout_flavour:
return AOUT_TARGET_FORMAT;
#endif
-#ifdef TE_GO32
+#if defined (OBJ_MAYBE_COFF) || defined (OBJ_COFF)
+# if defined (TE_PE) || defined (TE_PEP)
+ case bfd_target_coff_flavour:
+ return flag_code == CODE_64BIT ? "pe-x86-64" : "pe-i386";
+# elif defined (TE_GO32)
case bfd_target_coff_flavour:
return "coff-go32";
-#elif defined (OBJ_MAYBE_COFF)
+# else
case bfd_target_coff_flavour:
return "coff-i386";
+# endif
#endif
#if defined (OBJ_MAYBE_ELF) || defined (OBJ_ELF)
case bfd_target_elf_flavour:
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2009-09-09 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 3:32 Jan Kratochvil
2009-09-09 9:31 ` Alan Modra [this message]
2009-09-09 10:43 ` Jan Kratochvil
2009-09-09 13:19 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909093139.GA28290@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).