From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7840 invoked by alias); 14 Sep 2009 07:04:32 -0000 Received: (qmail 7823 invoked by uid 22791); 14 Sep 2009 07:04:31 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from nskntmtas03p.mx.bigpond.com (HELO nskntmtas03p.mx.bigpond.com) (61.9.168.143) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 07:04:25 +0000 Received: from nskntotgx01p.mx.bigpond.com ([121.209.33.16]) by nskntmtas03p.mx.bigpond.com with ESMTP id <20090914070423.EAAQ1820.nskntmtas03p.mx.bigpond.com@nskntotgx01p.mx.bigpond.com>; Mon, 14 Sep 2009 07:04:23 +0000 Received: from bubble.grove.modra.org ([121.209.33.16]) by nskntotgx01p.mx.bigpond.com with ESMTP id <20090914070422.BFRV22446.nskntotgx01p.mx.bigpond.com@bubble.grove.modra.org>; Mon, 14 Sep 2009 07:04:22 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2BE22170C881; Mon, 14 Sep 2009 16:34:22 +0930 (CST) Date: Mon, 14 Sep 2009 07:04:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sources.redhat.com Subject: Re: PATCH: PR ld/10630: Linker generates hidden local symbols Message-ID: <20090914070421.GW28290@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sources.redhat.com References: <20090911195011.GA30679@lucon.org> <20090912124204.GQ28290@bubble.grove.modra.org> <6dc9ffc80909120643g11378b6fp7a21ed80877794d9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6dc9ffc80909120643g11378b6fp7a21ed80877794d9@mail.gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150205.4AADEAF6.0113,ss=1,fgs=0 X-SIH-MSG-ID: qhgyGcT+XAr0zG56jm/mNg0iygbl8mEq454MWdNttxkbUkfFqbyBHdrAJuNRwIr21DlGNh6PPGIwYazkVLU= X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00380.txt.bz2 On Sat, Sep 12, 2009 at 06:43:01AM -0700, H.J. Lu wrote: > On Sat, Sep 12, 2009 at 5:42 AM, Alan Modra wrote: > > On Fri, Sep 11, 2009 at 12:50:12PM -0700, H.J. Lu wrote: > >> This patch turns off visibility on local symbol and dynamic local symbol. > >> Tested on Linux/ia32, Linux/ia64 and Linux/x86-64 as well as for > >> alpha-linux, cris-elf, s390-linux, sparc-linux, powerpc-linux and > >> xtensa-linux with cross binutils.  There are no regressions.  OK > >> to install? > > > > Does having non-default visibility on a local symbol break some > > application? > > It failed a test in elfutils on ia64 due to hidden dynamic local symbol, > which leads to rpm build failure. I'm not willing to OK your patch on the strength of a failed elfutils test. That's not to say I'm against the patch, just that I'm unsure what the ELF gabi intends. I won't be unhappy if someone else wants to OK it.. The ELF gabi says "A symbol with STB_LOCAL binding may not have STV_PROTECTED visibility." It does not say anything like this about STV_HIDDEN or STV_INTERNAL. That leads me to think that STB_LOCAL symbols may be marked STV_HIDDEN or STV_INTERNAL. (Such symbols wouldn't be inconsistent with the definitions of STB_LOCAL or STV_HIDDEN/STV_INTERNAL.) However, it does seem quite useless to have anything other than STV_DEFAULT local symbols, but maybe my imagination isn't good enough. -- Alan Modra Australia Development Lab, IBM