From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60070.outbound.protection.outlook.com [40.107.6.70]) by sourceware.org (Postfix) with ESMTPS id A389D3858D1E; Tue, 4 Oct 2022 10:16:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A389D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UFNxJBt5tKqP7R+VtRcQHVwBcXer97drdhivriGo8rCnOo08KBSDe3LtxBua1ZWQUtM5oOfmqnDFWq9fmxfD+VfECpeN1hnivAw21A1DzjMfriqqxXj4awsTfGH6Aw1sJUdjQfVHNCu9eMGJohJETGreioF/piHbnuzvDsMfMWjv11gPwF11hxhw7+ILkzMO/nAO21lpRb7oNotY1GY1rLkPs/HPx4eKJdXbURsC/BpPdZiyBeI43F+yH7wuZOudyCxy1EY5Zl5kpZN8Uht2ZTjBXVjmrzGLq+CltV4aXkm/uL4HKk3FD9u3BxM+NS0x4PnoIVB1E+Evwekjo9fBBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4oNMtIdhgl2LaBzqWPopHeyfassZnUJXYzUOUuZKpSg=; b=aaGfbHDNq1H8GLjqumL5VXsoToYFtzNKINVeRdBZQwTwdjNF8j4dWphgfpHBcC05uAHEMamHIP6m5rCP1hzHcN+/TZmwUt+Q76SsDLklLF1mSB2jXrRWJSHc/XwUxWZ1nlLOfT+6C/josM+2fJkhhTJ6FTRCAs590pm+0WhhwtTB18+asIweroTYG1jI7LOdZNgPhiI3bhDRtMwA4KhK+W728XCWWaVuvx+1CzkpO1y+wPSlAtqAgGzicTbZnAXdFtAfde0+gAQe8tfz17FyFl+T0vmZgsJkRqUVxWawUl1tFvSxXXeOF2SuV2teJCYrn5+DhYFh+Rv8uBKqPSyYjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4oNMtIdhgl2LaBzqWPopHeyfassZnUJXYzUOUuZKpSg=; b=hohyxX+UO1JivnWYlAQo+DQjviJSrC6d8lA9+40IB9dX2CY2Y3ZfzGcYCOunHJsPqL4PnCJqNDfgG4BzX4Ey2EAs9Jjk20KDZozfBvCDkzPjLdy/lnGi/VgSdg3lgRPx877xdGSOjZFqSbkGY0KEONR6N1bVwQXqayaER0efpM9EJC53GwD6nxE3NcBAbf3/rPh/Pl/iJZuPOnkqjz20u3etTYuJt9MMGJjNJ1rgQ/OjzXCYUz+84Ufd52ZvzHorjgPZFIIslCTUF1VBG/jILoys3mj1hiZ5XAS4rwFwAJju7IGnjeRQyIMxK7Ng/MyTtMzmmIecthpwYDRy2b0djg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct 2022 10:16:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 10:16:43 +0000 Message-ID: <200d2e03-e7d5-0a19-5f99-f0354bf93c74@suse.com> Date: Tue, 4 Oct 2022 12:16:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 1/2] RISC-V: Fix buffer overflow on print_insn_riscv Content-Language: en-US To: Tsukasa OI References: <5ca714bd-24d6-54c6-bce1-08cb3b77a47a@suse.com> Cc: Binutils , gdb-patches@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0082.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8898:EE_ X-MS-Office365-Filtering-Correlation-Id: 807e9bd5-095b-4afb-3f05-08daa5f18933 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ahI9172RASJk/A7Cuwc1tDuZorVRSB3bQvyqEf3STPpLutTN1GZ8wPhQV2vf3TcZq+tG9KU5RBwA50CAv6DcHUB3mqd8mmZvEh5VTO0lXZVNfJxdNOiFKTvZrxfXoaaDTF87qxkZsKDF7RLsqYFzmiNAAfjwytew7kvthSdT0TEnmTOyoFKKBh64+RyUJI09yaeJZdzkmDmaRUjixqlw9bU37m9H1mR5ix9AgeaZZums1ZO76NNuxwTngJKdFt6X2oqV0NnwSSTmC1mp+PgPNb4HUciRTb9WERREiVmBabU4PiScAIsMWqGKfPVtdvriQyjIi0xVrd6cwyCl6/qxpm5CX/zvYcBXOslyQSl9qX4KkblHrZifehLrOyaDA0zVa1aLvRziThkzddNe9urNVMa/2PeVbIW4ipHKMIQlDqnTyJodqFQWSjent5uiwayUquOLOV9k3oqxMR58oX3USjHjriHSjfKUXluizc3qU+nTYXN4yvuQzOAuaF7+aEnHepn5o5VKKGnree9Oh48gz7V/nQAQ1FdVX7ZHqFPiY+snT2u9Qp+pwv3LyDyOMw+K/Gw0uNyY27JxNhEbBdyfFDxjpQ/dVgDa4roc6lz4AjXt09UqOupSiFctnvcoVH1hdOCSuJdOUAHsP2oQjVBybJHQOvhjK4fbMOUR7TQ5qm1MZJIaS1WgYLaWmxWINbGYSrBcHo0ME47Km3MDEN2A+eKniKp4KHrdhje9lRjdYCNvJ0EGgGOF9DkmIJ6dJ2UonSvBibPoTx9AsSP6MuculcTE0TWdtX+FYBm8mgJzsQE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199015)(86362001)(36756003)(31696002)(38100700002)(6916009)(316002)(8676002)(6486002)(8936002)(5660300002)(4326008)(66946007)(2906002)(478600001)(41300700001)(186003)(6506007)(53546011)(66556008)(66476007)(2616005)(26005)(6512007)(66899015)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHpZSUk4M3p0MTN5RmpJZDhCMHdHVDAxTUNVbkJlRk1zTWZxaXZPUmQ1dlBx?= =?utf-8?B?UUlxT0N1anlJcmE5MXI2OGVJYlZucVFtQXp6dTRzb3hJOFpGbFBoQWFTRVls?= =?utf-8?B?dnh5dHRRaVh6YWZjVS93OE9KaThTQjNxcFhsQ3lzQ0ZRNGhneE1EZW45WGRC?= =?utf-8?B?aXZJVVNlZ3FaNUNwc0ljTjJ0Z0JwaFowbVRJNHoxRDgrR1RQRTFGR2lFYWE2?= =?utf-8?B?ZlhMNlB0U3ZaUE9tOXNJVVRNem1SSnpOb0ZvYXR3L1VmRXFsUldyZGdHYWJ5?= =?utf-8?B?S1h4MXdZaXNLQnB1aWxnZzg4LzQ4SlV0NHZleTY3NFMzbFFUVzByUTc4ZnRi?= =?utf-8?B?QTJIcUlmUVJDSWFsUFpVV0RsUHdJTE4xeFNZL1B2aXpiTm1PYlBMVktlUUU5?= =?utf-8?B?aDRXYU1yRlZWWE9NZTRFbjFZTnFGSC9TdUJrTWordElqNzVqN0EzK0xJNFRX?= =?utf-8?B?Wi9WajBoTS95T3hKMS9IbjBsc1d6citreGljK0FXVGxSZVRaRE4rajgzeVFM?= =?utf-8?B?bHJqTkd3SjhUOTFkRHlGdUhkTkZEQmJuTFhCKzBXZVhxZ0ZWYk1HcDdnQlJn?= =?utf-8?B?N0Z1M2xGbFNyMmIzQmlVM1FiM0hlUC9jd1JoWVJVdWFqc1dGRnEwYWFEVFZM?= =?utf-8?B?N0NWSEwwWmQ0STU4K0JqUEwvZTdsa0JLMGx2bzFzb2t3TldGdUswYzZ6eHJS?= =?utf-8?B?ZnpQR2g1WFovY0c5cjdaUHFYWWtiVzRXV2N1NWs1ZUQ3cGVLZlEwYWFSWWZy?= =?utf-8?B?N1pYSmJxS2MwUzZ6ZTFMWE9DM0h3YTVCc1Zqc3NjZng3Mnh4clpFNmF2ZUxu?= =?utf-8?B?Y1VkQ0FzdUgyRDEvZGg0aW5ITWdvWmVkS2RvRlcvNm9rQmhuS3BwSmIxME81?= =?utf-8?B?YmVZZjFCSUJFQmcrWHo3bytoQlR0dkpDVzNnem81RTN6WWQxbWN5M05hbnlm?= =?utf-8?B?TituWHRCVlRGS2M1WUlxNkJOZThGdmxUQ3FVNlpuWFFITUdZU3VjNUw5RVlG?= =?utf-8?B?dTN3Zi81TmRObHVqT2FEZ1N1eTNHdVdmUk4wclNQREw0bHJGSDJldlZLSER0?= =?utf-8?B?NjBIeTZPa1pTbnlGZkVnckh6Y01aNWhrTWdiOE8rSjVTZkRNY1dSNFV1TkZk?= =?utf-8?B?dURqZzRUQ2xweXhmMTNPTU1NVWg1WnJreVd3aC9RR3RZOVZ2NFZURVcrMDlO?= =?utf-8?B?WVRubVBEQTVVQ1FtQnlZZFpvS2VTQUMvL3Z0elNTUWNEdURaMTFUVGRWSUFE?= =?utf-8?B?NzZEdXlMd2dWSi85eXphaEh4c21XdWFTRDFLLzJSa3FWT2tkcDJXakM2TU5I?= =?utf-8?B?b0p4UUlXZVVVOWMvcnN3QUVQK3FwY0RXMHJ3dnpNeVU2dDJxaUN0OUVoNGgw?= =?utf-8?B?THdvNjNaWlJMcDRrN0g2WXlrTCtkdWdKOThBV1ZzanZvYk5rb2RSaUNBRkVp?= =?utf-8?B?YlNITXFzd2Y2TkxnMDlLeWYwamRkZll5TlVaY0QyOVJNUndkc01sMHpLc3gx?= =?utf-8?B?dEc3SDVqWWx1ck1tSllmbnVjQTBobUlzN252dmhGMnNvTXZhQUR0eUdqMjlL?= =?utf-8?B?REhLeGZYQ0J5bDU4dUdWQXpHb2ZvM29ZbThNNmJhQkYwSTJVZXRsRjloN3pz?= =?utf-8?B?MmNWeUNpUnJhVmxYaUJwT2FPNUhqTjFXaC84R1VkL1VLSHpwVk0raUNGaUpp?= =?utf-8?B?QjVSbFp0RjEySExDTUxQa3F3UHI5L3VTaUhXR0pKR0ZMNmovbFhGdlZaWkVE?= =?utf-8?B?TEdTcEEyR2l2TGI0YStsQm1qR0ZmNVRhSUYzaVlLK1Z5dWsrWnBpV2ptMnNk?= =?utf-8?B?alFaeUFCK0tyMHJ2Q3pYMTVad3BKcmZSRk5KNk5iOC9XZjd5QzQ4Z0xVQzJt?= =?utf-8?B?enA4RHhCMTdiaW5BSXlwMldDUjV1ZGhzbE02VGlWcllyMUZ4TDJVUW9xdURD?= =?utf-8?B?ejYwb09aM0N5T3NmYUhURmRtc2ROQW94RldDS3l6MlpPRzNHU0N4ZlhFQkds?= =?utf-8?B?TGpDRjhCODhvZGlTR1I4bGNqT2NTR3l2RC85d3dLS0JIMFMzakg4WFlpVDA0?= =?utf-8?B?YVRubjQ4WEJ1bG9iSFBwemwxYU15M2JQaDF3TlBjdHh2eExuaE9Vdkc2SmZR?= =?utf-8?Q?bpjaT2I7MIJVEh9gnufQ4ChRL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 807e9bd5-095b-4afb-3f05-08daa5f18933 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:16:43.5291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pBoBYyAq8sK2B5LOfFTXzB7lNAcCmCe1cFKUXzq5Qih2/P6SJMVotKcsenqd35Y+aWfclHhsCbDazr/eGZTZkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8898 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04.10.2022 12:13, Tsukasa OI wrote: > On 2022/10/04 18:58, Jan Beulich wrote: >> On 04.10.2022 11:45, Tsukasa OI wrote: >>> --- a/include/opcode/riscv.h >>> +++ b/include/opcode/riscv.h >>> @@ -55,6 +55,8 @@ static const char * const riscv_pred_succ[16] = >>> "i", "iw", "ir", "irw", "io", "iow", "ior", "iorw" >>> }; >>> >>> +#define RISCV_MAX_INSN_LEN 22 /* max 176-bit encoding. */ >> >> To be honest this still doesn't look sufficient to me: There's still >> no connection between this constant and riscv_insn_length(). Yet both >> want changing at the same time when it comes to insn length aspects. >> As said in reply to v1 - comments may be one way of dealing with this. >> We don't have BUILD_BUG_ON() or alike (and even if we had it wouldn't >> be usable in a portable way), so an actual build time check might not >> be feasible. A runtime check also doesn't look realistic, as >> >> gas_assert (riscv_insn_length(~0) == RISCV_MAX_INSN_LEN); >> >> wouldn't be correct, and I'm unconvinced of using other than the most >> simple ~0 as an argument here. > > I have to agree that the constant with no direct connection with > riscv_insn_length is not good but I don't come up with better solution > than this (with given constraints). > In any case, keeping this stack buffer overflow is definitely a bad idea > and we have to do something to deal with it in a days. Agreed. Hence could you add cross-referencing comments at both sides while introducing the #define, as a minimal measure? Jan