public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Remove dead code from gas/Makefile.am
@ 2010-02-05  1:10 Joseph S. Myers
  2010-02-05  5:34 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: Joseph S. Myers @ 2010-02-05  1:10 UTC (permalink / raw)
  To: binutils

I noticed that gas/Makefile.am had some apparently unused definitions, 
probably left over from an old form of dependency generation.  OK to 
commit this patch to remove them?

(I also noticed some of the other long lists in Makefile.am appear 
incomplete - for example, TARGET_CPU_CFILES is missing at least 
tc-i386-intel.c and tc-score7.c, TARG_ENV_HFILES is missing at least 
te-uclinux.h.  But I have not made any thorough check for such issues so 
do not propose a patch for them.  The effects of such missing entries 
include messages missing from gas.pot.)

2010-02-05  Joseph Myers  <joseph@codesourcery.com>

	* Makefile.am (CPU_TYPES, OBJ_FORMATS, CPU_OBJ_VALID,
	MULTI_CPU_TYPES, MULTI_CPU_OBJ_VALID): Remove.
	* Makefile.in: Regenerate.

Index: Makefile.am
===================================================================
RCS file: /cvs/src/src/gas/Makefile.am,v
retrieving revision 1.186
diff -u -r1.186 Makefile.am
--- Makefile.am	29 Sep 2009 14:17:06 -0000	1.186
+++ Makefile.am	5 Feb 2010 00:57:32 -0000
@@ -36,142 +36,6 @@
 IT_DEPS=$(srcdir)/itbl-parse.y $(srcdir)/itbl-lex.l $(srcdir)/config/itbl-@target_cpu_type@.h
 IT_OBJS=itbl-parse.o itbl-lex.o itbl-ops.o
 
-# CPU types.  This is only used for dependency information.
-
-CPU_TYPES = \
-	alpha \
-	arc \
-	arm \
-	avr \
-	bfin \
-	cr16 \
-	cris \
-	crx \
-	d10v \
-	d30v \
-	dlx \
-	fr30 \
-	frv \
-	h8300 \
-	hppa \
-	i370 \
-	i386 \
-	i860 \
-	i960 \
-	ia64 \
-	ip2k \
-	lm32 \
-	m32c \
-	m32r \
-	m68hc11 \
-	m68k \
-	maxq \
-	mcore \
-	mep \
-	microblaze \
-	mips \
-	mmix \
-	mn10200 \
-	mn10300 \
-	msp430 \
-	mt \
-	ns32k \
-	openrisc \
-	or32 \
-	pdp11 \
-	pj \
-	ppc \
-	rx \
-	s390 \
-	score \
-	sh \
-	sh64 \
-	sparc \
-	spu \
-	tic30 \
-	tic4x \
-	tic54x \
-	v850 \
-	vax \
-	xc16x \
-	xstormy16 \
-	xtensa \
-	z80 \
-	z8k
-
-# Object format types.  This is only used for dependency information.
-# We deliberately omit SOM, since it does not work as a cross assembler.
-
-OBJ_FORMATS = \
-	aout \
-	coff \
-	ecoff \
-	elf \
-	evax \
-	macho
-
-# This is an sh case which sets valid according to whether the CPU
-# type in the shell variable c and the OS type in the shell variable o
-# are supported.  This helps cuts down on the amount of dependency
-# information.
-
-CPU_OBJ_VALID = \
-	valid= ; \
-	case $$o in \
-	aout) \
-	  case $$c in \
-	  arm | cris | i386 | m68k | ns32k | pdp11 | sparc | tic30 | vax) \
-	    valid=yes ;; \
-	  esac ;; \
-	coff) \
-	  case $$c in \
-	  arm | h8300 | i386 | i960 | m68k | maxq | mcore | mips | or32 \
-		| ppc | sh | sparc | tic* | xscale | z80 | z8k) \
-	    valid=yes ;; \
-	  esac ;; \
-	ecoff) \
-	  case $$c in \
-	  mips | alpha) valid=yes ;; \
-	  esac ;; \
-	elf) valid=yes ; \
-	  case $$c in \
-	  maxq | ns32k | tic* | z80 | z8k) valid= ;; \
-	  esac ;; \
-	evax) \
-	  case $$c in \
-	  alpha) valid=yes ;; \
-	  esac ;; \
-	macho) \
-	  case $$c in \
-	  i386) valid=yes ;; \
-	  esac ;; \
-	vms) \
-	  case $$c in \
-	  vax) valid=yes ;; \
-	  esac ;; \
-	esac;
-
-# These are like CPU_TYPES and CPU_OBJ_VALID, for the obj=multi case.
-
-MULTI_CPU_TYPES = i386 mips cris
-
-MULTI_CPU_OBJ_VALID = \
-	valid= ; \
-	case $$o in \
-	aout) \
-	  case $$c in \
-	  i386 | cris) valid=yes ;; \
-	  esac ;; \
-	coff) \
-	  case $$c in \
-	  i386 | mips) valid=yes ;; \
-	  esac ;; \
-	ecoff) \
-	  case $$c in \
-	  mips) valid=yes ;; \
-	  esac ;; \
-	elf) valid=yes ;; \
-	esac;
 
 # Regular source files.
 

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Remove dead code from gas/Makefile.am
  2010-02-05  1:10 Remove dead code from gas/Makefile.am Joseph S. Myers
@ 2010-02-05  5:34 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2010-02-05  5:34 UTC (permalink / raw)
  To: Joseph S. Myers; +Cc: binutils

On Fri, Feb 05, 2010 at 01:09:49AM +0000, Joseph S. Myers wrote:
> I noticed that gas/Makefile.am had some apparently unused definitions, 
> probably left over from an old form of dependency generation.  OK to 
> commit this patch to remove them?

Yes, thanks.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-05  5:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-05  1:10 Remove dead code from gas/Makefile.am Joseph S. Myers
2010-02-05  5:34 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).