public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: DJ Delorie <dj@redhat.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix toplevel configure --enable-multilib handling (PR  bootstrap/43328)
Date: Wed, 31 Mar 2010 06:08:00 -0000	[thread overview]
Message-ID: <20100331054445.GA6102@gmx.de> (raw)
In-Reply-To: <201003301930.o2UJU93c016403@greed.delorie.com>

* DJ Delorie wrote on Tue, Mar 30, 2010 at 09:30:09PM CEST:
> 
> > Ping <http://gcc.gnu.org/ml/gcc-patches/2010-03/msg00509.html>
> 
> Ok.

Thanks for your review.

FYI binutils and gdb-patches, I'm syncing this from GCC.

Cheers,
Ralf

2010-03-31  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	PR bootstrap/43328
	* configure.ac: Do not pass --enable-multilib nor
	--disable-multilib in baseargs.  Accept explicitly passed
	--enable_multilib.
	* configure: Regenerate.

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/configure.ac,v
retrieving revision 1.98
diff -u -r1.98 configure.ac
--- configure.ac	23 Mar 2010 16:05:34 -0000	1.98
+++ configure.ac	31 Mar 2010 05:42:40 -0000
@@ -2882,6 +2882,9 @@
       skip_next=$separate_arg
       continue
       ;;
+    --enable-multilib | --disable-multilib)
+      continue
+      ;;
     -*)
       # An option.  Add it.
       case $ac_arg in
@@ -2950,10 +2953,12 @@
   target_configargs="--with-cross-host=${host_noncanonical} ${target_configargs}"
 fi
 
-# Default to --enable-multilib.
-if test x${enable_multilib} = x ; then
+# Pass --enable-multilib to target dirs; default to --enable-multilib.
+case $enable_multilib in
+'' | yes)
   target_configargs="--enable-multilib ${target_configargs}"
-fi
+  ;;
+esac
 
 # Pass --with-newlib if appropriate.  Note that target_configdirs has
 # changed from the earlier setting of with_newlib.

       reply	other threads:[~2010-03-31  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100313093157.GA11397@gmx.de>
     [not found] ` <20100330184945.GC32187@gmx.de>
     [not found]   ` <201003301930.o2UJU93c016403@greed.delorie.com>
2010-03-31  6:08     ` Ralf Wildenhues [this message]
     [not found]     ` <k2i84fc9c001004010619j6b37c9fer6a3ace667cdc7b7c@mail.gmail.com>
     [not found]       ` <20100401163649.GA20241@gmx.de>
2010-04-08 19:44         ` Ralf Wildenhues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100331054445.GA6102@gmx.de \
    --to=ralf.wildenhues@gmx.de \
    --cc=binutils@sourceware.org \
    --cc=dj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).