From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4240 invoked by alias); 21 Oct 2010 22:19:58 -0000 Received: (qmail 4224 invoked by uid 22791); 21 Oct 2010 22:19:57 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Oct 2010 22:19:52 +0000 Received: by pwj2 with SMTP id 2so286859pwj.0 for ; Thu, 21 Oct 2010 15:19:51 -0700 (PDT) Received: by 10.142.154.20 with SMTP id b20mr1466816wfe.23.1287699591286; Thu, 21 Oct 2010 15:19:51 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id e14sm3171661wfg.20.2010.10.21.15.19.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 21 Oct 2010 15:19:50 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 3ECFD170C206; Fri, 22 Oct 2010 08:49:44 +1030 (CST) Date: Thu, 21 Oct 2010 22:19:00 -0000 From: Alan Modra To: Mark Mitchell Cc: Ian Lance Taylor , binutils@sourceware.org Subject: Re: RFC: COMDAT group names become anonymouse local symbols Message-ID: <20101021221944.GX26553@bubble.grove.modra.org> Mail-Followup-To: Mark Mitchell , Ian Lance Taylor , binutils@sourceware.org References: <20101019200838.8A9725664F9@henry1.codesourcery.com> <20101021001823.GQ26553@bubble.grove.modra.org> <4CBF89DF.5070509@codesourcery.com> <4CBFC470.5060202@codesourcery.com> <20101021062426.GU26553@bubble.grove.modra.org> <4CC06D28.5070900@codesourcery.com> <20101021185044.GA19120@caradoc.them.org> <4CC0A0E7.9090803@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CC0A0E7.9090803@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00355.txt.bz2 On Thu, Oct 21, 2010 at 01:21:59PM -0700, Mark Mitchell wrote: > I need to write test cases, ChangeLog, and run the testsuite -- but I > thought it would be worth posting here to get comments since I'm a GAS > novice. Does this look sensible? Are the arguments to symbol_new for > segment and fragment plausible? I think you'll find that build_group_lists should only run once. Move the group handling code in elf_frob_file to elf_adjust_symtab, then tweak it to create a symbol when necessary. Create the sym after subseg_force_new so as to set segment and frag to the group section. -- Alan Modra Australia Development Lab, IBM