From: Alan Modra <amodra@gmail.com>
To: Mark Mitchell <mark@codesourcery.com>
Cc: Ian Lance Taylor <iant@google.com>, binutils@sourceware.org
Subject: Re: RFC: COMDAT group names become anonymouse local symbols
Date: Fri, 22 Oct 2010 07:16:00 -0000 [thread overview]
Message-ID: <20101022071548.GF26553@bubble.grove.modra.org> (raw)
In-Reply-To: <4CC12AE7.3010802@codesourcery.com>
On Thu, Oct 21, 2010 at 11:10:47PM -0700, Mark Mitchell wrote:
> 2010-10-21 Mark Mitchell <mark@codesourcery.com>
>
> * config/obj-elf.c (elf_adjust_symtab): New. Move group section
> processing here from elf_frob_file. Ensure that group signature
> symbols have the name of the group.
> (elf_frob_file): Move group section processing to
> elf_adjust_symtab.
> * config/obj-elf.h (elf_adjust_symtab): Declare.
> (obj_adjust_symtab): Define.
>
> 2010-10-21 Mark Mitchell <mark@codesourcery.com>
>
> * gas/elf/elf.exp: Add group0c test.
> * gas/elf/group0c.d: New.
> * gas/elf/group0a.d: Expect ".group" for the name of group
> sections.
> * gas/elf/group0b.d: Likewise.
> * gas/elf/group1a.d: Likewise.
> * gas/elf/group1b.d: Likewise.
> * gas/elf/groupautoa.d: Likewise.
> * gas/elf/groupautob.d: Likewise.
> * gas/elf/section4.d: Likewise.
Looking good but needs a few more patches, and you need to run the
full binutils testsuite.
grep obj_adjust_symtab says you have a tweak to make to config/tc-arm.c
egrep '(group section|GROUP)' will hit a few more testcases in
gas/testsuite/gas/ia64/, binutils/testsuite/binutils-all/, and
ld/testsuite/ld-elf/
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2010-10-22 7:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 20:08 Mark Mitchell
2010-10-20 18:05 ` Cary Coutant
2010-10-20 18:19 ` Mark Mitchell
2010-10-21 6:12 ` Cary Coutant
2010-10-21 0:18 ` Alan Modra
2010-10-21 0:31 ` Mark Mitchell
2010-10-21 1:04 ` Ian Lance Taylor
2010-10-21 4:41 ` Mark Mitchell
2010-10-21 5:19 ` H.J. Lu
2010-10-21 5:27 ` Mark Mitchell
2010-10-21 5:41 ` H.J. Lu
2010-10-21 5:42 ` Mark Mitchell
2010-10-21 6:24 ` Alan Modra
2010-10-21 16:41 ` Mark Mitchell
2010-10-21 18:50 ` Daniel Jacobowitz
2010-10-21 20:22 ` Mark Mitchell
2010-10-21 22:19 ` Alan Modra
2010-10-21 22:41 ` Mark Mitchell
2010-10-21 23:11 ` Alan Modra
2010-10-22 3:23 ` Mark Mitchell
2010-10-22 4:33 ` Alan Modra
2010-10-22 6:10 ` Mark Mitchell
2010-10-22 7:16 ` Alan Modra [this message]
2010-10-22 15:34 ` Mark Mitchell
2010-10-23 8:16 ` Alan Modra
2010-10-23 18:05 ` Mark Mitchell
2010-10-24 1:15 ` Hans-Peter Nilsson
2010-10-24 1:43 ` Mark Mitchell
2010-10-24 3:50 ` Hans-Peter Nilsson
2010-10-24 4:34 ` Mark Mitchell
2010-10-25 11:45 ` Hans-Peter Nilsson
2010-10-25 12:39 ` Alan Modra
2010-10-25 15:22 ` Mark Mitchell
2010-10-26 3:45 ` Alan Modra
2010-10-26 15:48 ` Dave Korn
2010-10-26 15:49 ` Mark Mitchell
2010-10-26 15:59 ` Dave Korn
2010-10-26 16:12 ` Dave Korn
2010-10-21 2:12 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022071548.GF26553@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=iant@google.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).