* Re: src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h ... [not found] <20101029121039.19742.qmail@sourceware.org> @ 2010-10-29 16:10 ` Joseph S. Myers 2010-10-29 16:17 ` H.J. Lu 0 siblings, 1 reply; 5+ messages in thread From: Joseph S. Myers @ 2010-10-29 16:10 UTC (permalink / raw) To: hjl; +Cc: binutils On Fri, 29 Oct 2010, hjl@sourceware.org wrote: > ld/testsuite/ld-elf: compress.exp compress1.s compress1a.d > compress1b.d compress1c.d FAIL: ld-elf/compress1c appears for targets not supporting -shared; it should be marked UNSUPPORTED for them, like various other -shared tests, instead. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h ... 2010-10-29 16:10 ` src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h Joseph S. Myers @ 2010-10-29 16:17 ` H.J. Lu 2010-10-29 20:25 ` Thomas Schwinge 0 siblings, 1 reply; 5+ messages in thread From: H.J. Lu @ 2010-10-29 16:17 UTC (permalink / raw) To: Joseph S. Myers; +Cc: binutils On Fri, Oct 29, 2010 at 9:10 AM, Joseph S. Myers <joseph@codesourcery.com> wrote: > On Fri, 29 Oct 2010, hjl@sourceware.org wrote: > >> ld/testsuite/ld-elf: compress.exp compress1.s compress1a.d >> compress1b.d compress1c.d > > FAIL: ld-elf/compress1c > > appears for targets not supporting -shared; it should be marked > UNSUPPORTED for them, like various other -shared tests, instead. > I checked in this patch. -- H.J. --- diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog index 056be7f..18533d6 100644 --- a/ld/testsuite/ChangeLog +++ b/ld/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2010-10-29 H.J. Lu <hongjiu.lu@intel.com> + * ld-elf/compress1c.d: Only run for Linux targets. + +2010-10-29 H.J. Lu <hongjiu.lu@intel.com> + * ld-elf/compress.exp: New. * ld-elf/compress1.s: Likewise. * ld-elf/compress1a.d: Likewise. diff --git a/ld/testsuite/ld-elf/compress1c.d b/ld/testsuite/ld-elf/compress1c.d index 2822ce6..7be7cfb 100644 --- a/ld/testsuite/ld-elf/compress1c.d +++ b/ld/testsuite/ld-elf/compress1c.d @@ -2,6 +2,7 @@ #as: --compress-debug-sections #ld: -shared #readelf: -S --wide +#target: *-*-linux* #failif ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h ... 2010-10-29 16:17 ` H.J. Lu @ 2010-10-29 20:25 ` Thomas Schwinge 2010-11-02 2:15 ` Alan Modra 0 siblings, 1 reply; 5+ messages in thread From: Thomas Schwinge @ 2010-10-29 20:25 UTC (permalink / raw) To: H.J. Lu; +Cc: Joseph S. Myers, binutils [-- Attachment #1: Type: text/plain, Size: 1292 bytes --] Hello! On Fri, Oct 29, 2010 at 09:17:42AM -0700, H.J. Lu wrote: > On Fri, Oct 29, 2010 at 9:10 AM, Joseph S. Myers > <joseph@codesourcery.com> wrote: > > On Fri, 29 Oct 2010, hjl@sourceware.org wrote: > >> ld/testsuite/ld-elf: compress.exp compress1.s compress1a.d > >> compress1b.d compress1c.d > > > > FAIL: ld-elf/compress1c > > > > appears for targets not supporting -shared; it should be marked > > UNSUPPORTED for them, like various other -shared tests, instead. > > I checked in this patch. > > 2010-10-29 H.J. Lu <hongjiu.lu@intel.com> > > + * ld-elf/compress1c.d: Only run for Linux targets. > +++ b/ld/testsuite/ld-elf/compress1c.d > @@ -2,6 +2,7 @@ > #as: --compress-debug-sections > #ld: -shared > #readelf: -S --wide > +#target: *-*-linux* Hrm, in which way is this test specific to a Linux target? In other words, doing this is precisely what I'm suggesting *to avoid* in my patch posted at <http://sourceware.org/ml/binutils/2010-10/msg00485.html>. Can't we solve this and similar issues properly instead? For example, by adding infrastructure to whitelist / blacklist these tests based on *real* specifics, which target: *-*-linux* is not, in my opinion. Other opinions? Regards, Thomas [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h ... 2010-10-29 20:25 ` Thomas Schwinge @ 2010-11-02 2:15 ` Alan Modra 2010-11-02 8:31 ` Thomas Schwinge 0 siblings, 1 reply; 5+ messages in thread From: Alan Modra @ 2010-11-02 2:15 UTC (permalink / raw) To: Thomas Schwinge; +Cc: H.J. Lu, Joseph S. Myers, binutils On Fri, Oct 29, 2010 at 08:39:40PM +0200, Thomas Schwinge wrote: > Hrm, in which way is this test specific to a Linux target? In which way are you worse off than before HJ added this test? -- Alan Modra Australia Development Lab, IBM ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h ... 2010-11-02 2:15 ` Alan Modra @ 2010-11-02 8:31 ` Thomas Schwinge 0 siblings, 0 replies; 5+ messages in thread From: Thomas Schwinge @ 2010-11-02 8:31 UTC (permalink / raw) To: H.J. Lu, Joseph S. Myers, binutils [-- Attachment #1: Type: text/plain, Size: 591 bytes --] Hello! On Tue, Nov 02, 2010 at 12:45:01PM +1030, Alan Modra wrote: > On Fri, Oct 29, 2010 at 08:39:40PM +0200, Thomas Schwinge wrote: > > Hrm, in which way is this test specific to a Linux target? > > In which way are you worse off than before HJ added this test? We're not. In relation to my ``[PATCH] Improve binutils testsuite coverage for GNU/Hurd (and kFreeBSD?)'', I was just pointing out that this is not a proper solution in my opinion: support for -shared is not Linux-specific. (But probably nobody is interested in solving this properly.) Regards, Thomas [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-02 8:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20101029121039.19742.qmail@sourceware.org>
2010-10-29 16:10 ` src bfd/ChangeLog bfd/archive.c bfd/bfd-in2.h Joseph S. Myers
2010-10-29 16:17 ` H.J. Lu
2010-10-29 20:25 ` Thomas Schwinge
2010-11-02 2:15 ` Alan Modra
2010-11-02 8:31 ` Thomas Schwinge
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).