From: Alan Modra <amodra@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Dave Korn <dave.korn.cygwin@gmail.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] Re: more plugin testsuite issues
Date: Tue, 16 Nov 2010 23:01:00 -0000 [thread overview]
Message-ID: <20101116230115.GB5527@bubble.grove.modra.org> (raw)
In-Reply-To: <m2r5el3p5i.fsf@igel.home>
On Tue, Nov 16, 2010 at 11:00:09PM +0100, Andreas Schwab wrote:
> Dave Korn <dave.korn.cygwin@gmail.com> writes:
>
> > +# Rather than having libs we just define dummy values for anything
> > +# we may need to link a target exe; we aren't going to run it anyway.
> > +set libs "[ld_simple_link_defsyms] --defsym ${_}printf=0 --defsym ${_}puts=0"
>
> That does not work.
>
> /home/andreas/src/binutils/binutils/ld/testsuite/ld-plugin/main.c:11: relocation truncated to fit: R_PPC_REL24 against symbol `puts' defined in *ABS* section in tmpdir/main.x
That reminds me. I've had this in my tree for a while but hadn't
committed it.
* ld-plugin/plugin.exp: Define printf and puts as main.
Index: ld/testsuite/ld-plugin/plugin.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-plugin/plugin.exp,v
retrieving revision 1.5
diff -u -p -r1.5 plugin.exp
--- ld/testsuite/ld-plugin/plugin.exp 5 Nov 2010 07:23:09 -0000 1.5
+++ ld/testsuite/ld-plugin/plugin.exp 16 Nov 2010 22:50:52 -0000
@@ -87,7 +87,7 @@ set testobjfiles "tmpdir/main.o tmpdir/f
set testobjfiles_notext "tmpdir/main.o tmpdir/func.o"
# Rather than having libs we just define dummy values for anything
# we may need to link a target exe; we aren't going to run it anyway.
-set libs "[ld_simple_link_defsyms] --defsym ${_}printf=0 --defsym ${_}puts=0"
+set libs "[ld_simple_link_defsyms] --defsym ${_}printf=${_}main --defsym ${_}puts=${_}main"
set plugin_tests [list \
[list "load plugin" "-plugin $plugin_path \
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2010-11-16 23:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 4:54 Alan Modra
2010-10-26 16:52 ` Dave Korn
2010-10-28 8:16 ` Alan Modra
2010-11-04 16:11 ` Dave Korn
2010-11-04 19:48 ` [PATCH] " Dave Korn
2010-11-04 23:55 ` Alan Modra
2010-11-05 0:13 ` Dave Korn
2010-11-05 3:00 ` Alan Modra
2010-11-05 4:26 ` Dave Korn
2010-11-05 5:59 ` Alan Modra
2010-11-05 7:23 ` Dave Korn
2010-11-16 22:00 ` Andreas Schwab
2010-11-16 23:01 ` Alan Modra [this message]
2010-11-17 3:13 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116230115.GB5527@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=dave.korn.cygwin@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).