RFA: gas S_IS_HIDDEN? (detecting hidden symbols in gas)

RFA: gas S_IS_HIDDEN? (detecting hidden symbols in gas)

[Matt Thomas]

For the VAX, i need to be detect whether a symbol is hidden or not
(a "global" hidden symbol can be used in an indirect addressing manner
in PIC mode while a global non-hiddden symbol can not be).

I was surprised to see there was no S_IS_HIDDEN.  So in tc-vax.c
I added:

#ifdef OBJ_ELF
static int
S_IS_HIDDEN(symbolS *symbolP)
{  
  asymbol *bfdsym; 
  elf_symbol_type *elfsym;
   
  bfdsym = symbol_get_bfdsym (symbolP);
  elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
   
  assert (elfsym);

  return (elfsym->internal_elf_sym.st_other & 3) == STV_HIDDEN;
}
#endif

The routine works fine but it doesn't belong in tc-vax.c.  
So the question is where does it belong?  config/obj-elf.c?
symbols.c?  someplace else?  

Re: RFA: gas S_IS_HIDDEN? (detecting hidden symbols in gas)

[Alan Modra]

On Wed, Dec 08, 2010 at 09:47:32AM -0800, Matt Thomas wrote:
> I was surprised to see there was no S_IS_HIDDEN.  So in tc-vax.c
> I added:

I would be inclined to use S_GET_OTHER.

-- 
Alan Modra
Australia Development Lab, IBM

Re: RFA: gas S_IS_HIDDEN? (detecting hidden symbols in gas)

[Matt Thomas]

On Dec 8, 2010, at 3:44 PM, Alan Modra wrote:

> On Wed, Dec 08, 2010 at 09:47:32AM -0800, Matt Thomas wrote:
>> I was surprised to see there was no S_IS_HIDDEN.  So in tc-vax.c
>> I added:
> 
> I would be inclined to use S_GET_OTHER.

Ahhh.  Perfect.  I knew there had to be something.

That means I can get by with:

#ifdef OBJ_ELF
              && ELF_ST_VISIBILITY (S_GET_OTHER (fragP->fr_symbol)) != STV_HIDDEN  
#endif 

Thanks