* [PATCH] binutils testsuite fix for tcl8.3
@ 2010-12-31 18:20 John David Anglin
2011-01-03 12:08 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: John David Anglin @ 2010-12-31 18:20 UTC (permalink / raw)
To: binutils
The attached change fixes a problem running the binutils testsuites
with tcl8.3. It doesn't support "eq".
Ok?
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
2010-12-31 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* lib/binutils-common.exp (regexp_diff): Use "==" instead of "eq".
Index: binutils/testsuite/lib/binutils-common.exp
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/lib/binutils-common.exp,v
retrieving revision 1.3
diff -u -3 -p -r1.3 binutils-common.exp
--- binutils/testsuite/lib/binutils-common.exp 9 Dec 2010 23:57:21 -0000 1.3
+++ binutils/testsuite/lib/binutils-common.exp 31 Dec 2010 17:12:35 -0000
@@ -237,7 +237,7 @@ proc regexp_diff { file_1 file_2 args }
set diff_pass 1
break
}
- set negated [expr { [string index $line_b 0] eq "!" }]
+ set negated [expr { [string index $line_b 0] == "!" }]
set line_bx [string range $line_b $negated end]
set n [expr { $negated ? "! " : "" }]
# Substitute on the reference.
@@ -275,7 +275,7 @@ proc regexp_diff { file_1 file_2 args }
set differences 1
break
} else {
- set negated [expr { [string index $line_b 0] eq "!" }]
+ set negated [expr { [string index $line_b 0] == "!" }]
set line_bx [string range $line_b $negated end]
set n [expr { $negated ? "! " : "" }]
set s [expr { $negated ? " " : "" }]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] binutils testsuite fix for tcl8.3
2010-12-31 18:20 [PATCH] binutils testsuite fix for tcl8.3 John David Anglin
@ 2011-01-03 12:08 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2011-01-03 12:08 UTC (permalink / raw)
To: John David Anglin; +Cc: John David Anglin, binutils
Hi Dave
Patch approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-03 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-31 18:20 [PATCH] binutils testsuite fix for tcl8.3 John David Anglin
2011-01-03 12:08 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).