[patch] readelf --debug-dump=gdb_index support for v4

[patch] readelf --debug-dump=gdb_index support for v4

[Jan Kratochvil]

Hello,

GDB HEAD has now started producing + requiring for consumption only .gdb_index
section version 4.
	Re: .gdb_index version 4? [Re: [commit] fix symtab/12302]
	http://sourceware.org/ml/gdb-patches/2011-01/msg00502.html

Here is the reader update.  OK to check in?


Thanks,
Jan


binutils/
2011-01-25  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* dwarf.c (display_gdb_index): Support version 4, warn on version 3.

--- binutils/dwarf.c	15 Dec 2010 08:45:59 -0000	1.82
+++ binutils/dwarf.c	25 Jan 2011 17:26:30 -0000
@@ -4893,8 +4893,15 @@ display_gdb_index (struct dwarf_section 
 
   /* Prior versions are obsolete, and future versions may not be
      backwards compatible.  */
-  if (version != 3)
+  switch (version)
     {
+    case 3:
+      warn (_("gdb_index version 3 is ignored by GDB as it has broken "
+	      "Address table\n"));
+      break;
+    case 4:
+      break;
+    default:
       warn (_("Unsupported version %lu.\n"), (unsigned long) version);
       return 0;
     }

Re: [patch] readelf --debug-dump=gdb_index support for v4

[Jan Kratochvil]

On Tue, 25 Jan 2011 18:37:49 +0100, Doug Evans wrote:
> IWBN to reword the warning below to something like "The address table data
> in version 3 may be wrong."

Updated.


Thanks,
Jan


binutils/
2011-01-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
	    Doug Evans  <dje@google.com>

	* dwarf.c (display_gdb_index): Support version 4, warn on version 3.

--- binutils/dwarf.c	15 Dec 2010 08:45:59 -0000	1.82
+++ binutils/dwarf.c	25 Jan 2011 17:42:44 -0000
@@ -4893,8 +4893,14 @@ display_gdb_index (struct dwarf_section 
 
   /* Prior versions are obsolete, and future versions may not be
      backwards compatible.  */
-  if (version != 3)
+  switch (version)
     {
+    case 3:
+      warn (_("The address table data in version 3 may be wrong.\n"));
+      break;
+    case 4:
+      break;
+    default:
       warn (_("Unsupported version %lu.\n"), (unsigned long) version);
       return 0;
     }

Re: [patch] readelf --debug-dump=gdb_index support for v4

[Nick Clifton]

Hi Jan,

> binutils/
> 2011-01-25  Jan Kratochvil<jan.kratochvil@redhat.com>
> 	Doug Evans<dje@google.com>
>
> 	* dwarf.c (display_gdb_index): Support version 4, warn on version 3.

Approved - please apply.

Cheers
   Nick

Re: [patch] readelf --debug-dump=gdb_index support for v4

[Jan Kratochvil]

Hello Nick,

On Wed, 26 Jan 2011 11:02:24 +0100, Nick Clifton wrote:
> >binutils/
> >2011-01-25  Jan Kratochvil<jan.kratochvil@redhat.com>
> >	Doug Evans<dje@google.com>
> >
> >	* dwarf.c (display_gdb_index): Support version 4, warn on version 3.
> 
> Approved - please apply.

Checked in:
	http://sourceware.org/ml/binutils-cvs/2011-01/msg00145.html


Thanks,
Jan